Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: python versions must match python dependency #8897

Merged
merged 2 commits into from
Oct 12, 2020
Merged

style: python versions must match python dependency #8897

merged 2 commits into from
Oct 12, 2020

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Oct 10, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Require that all strings that match pythonX.Y or python@X.Y match versions with the specified python dependency

Partially influenced by discussion at Homebrew/homebrew-core#62406 (comment)

This change should make the migration easier because brew style --fix will update python references to the new python version

CC: @iMichka and @fxcoudert

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
mkmik Marko Mikulicic
Copy link
Contributor

@jonchang jonchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff!

@fxcoudert
Copy link
Member

Python 3.10 is coming, can you adjust the code to deal with it?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Rylan12
Copy link
Member Author

Rylan12 commented Oct 11, 2020

Python 3.10 is coming, can you adjust the code to deal with it?

Good idea. Done.

@Rylan12 Rylan12 merged commit abf214c into Homebrew:master Oct 12, 2020
@Rylan12 Rylan12 deleted the style-python-version branch October 12, 2020 12:22
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants