Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew.sh: reorder to speedup shellenv. #8904

Merged
merged 1 commit into from
Oct 12, 2020
Merged

brew.sh: reorder to speedup shellenv. #8904

merged 1 commit into from
Oct 12, 2020

Conversation

MikeMcQuaid
Copy link
Member

Reorder and restructure this file to make it as fast as possible for e.g. brew --prefix. Once we have that, also give brew shellenv short-circuit command execution to make it as fast as possible.

On my machine (with a warm cache) this gets:

brew shellenv  0.01s user 0.03s system 100% cpu 0.038 total

Compared to:

brew shellenv  0.09s user 0.19s system 100% cpu 0.277 total

before this commit.

Credit to @metaColin for giving me this idea in #8846 (comment)

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
mkmik Marko Mikulicic
Reorder and restructure this file to make it as fast as possible for
e.g. `brew --prefix`. Once we have that, also give `brew shellenv`
short-circuit command execution to make it as fast as possible.

On my machine (with a warm cache) this gets:

```
brew shellenv  0.01s user 0.03s system 100% cpu 0.038 total
```

Compared to:

```
brew shellenv  0.09s user 0.19s system 100% cpu 0.277 total
```

before this commit.
@MikeMcQuaid MikeMcQuaid merged commit e9987cd into Homebrew:master Oct 12, 2020
@MikeMcQuaid MikeMcQuaid deleted the shellenv-brew.sh branch October 12, 2020 08:50
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants