Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr-pull: clean up review signoff trailer code #8906

Merged
merged 1 commit into from
Oct 12, 2020
Merged

pr-pull: clean up review signoff trailer code #8906

merged 1 commit into from
Oct 12, 2020

Conversation

jonchang
Copy link
Contributor

@jonchang jonchang commented Oct 12, 2020

This should avoid situations that mangle the trailers when trailers already exist but we want to add review signoff trailers. After this pull request, the commit messages look like:

Homebrew/homebrew-core@c6a0ed8

r 4.0.3

* r 4.0.3
* r: update license

Closes #62704.

Co-authored-by: chenrui <chenrui333@gmail.com>
Signed-off-by: FX Coudert <fxcoudert@gmail.com>
Signed-off-by: Jonathan Chang <me@jonathanchang.org>

Homebrew/homebrew-core@7db0bc2

conan 1.30.1

Closes #62710.

Signed-off-by: Rui Chen <rui@meetup.com>
Signed-off-by: FX Coudert <fxcoudert@gmail.com>
Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@jonchang jonchang merged commit 84930af into Homebrew:master Oct 12, 2020
@jonchang jonchang deleted the tweak-signoff branch October 12, 2020 11:11
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants