Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update for new autosquash on automerge #8917

Merged
merged 1 commit into from
Oct 17, 2020
Merged

docs: update for new autosquash on automerge #8917

merged 1 commit into from
Oct 17, 2020

Conversation

jonchang
Copy link
Contributor

@jonchang jonchang commented Oct 13, 2020

Update the Homebrew/core maintainer guidelines to talk about the new automatic pull request squashing/amending when BrewTestBot thinks it knows how to do it.

Closes #8093.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Sorry, something went wrong.

@jonchang jonchang requested a review from a team October 13, 2020 12:20
@jonchang jonchang merged commit aa97179 into Homebrew:master Oct 17, 2020
@jonchang jonchang deleted the update-docs-for-autosquash-automerge branch October 17, 2020 07:12
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement autosquash for homebrew-core pull requests
4 participants