Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build(deps): bump ruby-macho from 2.2.0 to 2.3.0 in /Library/Homebrew" #8923

Conversation

MikeMcQuaid
Copy link
Member

Reverts #8913

Due to #8922
Fixes #8922

CC @mistydemeo @woodruffw

Perhaps this should only warn on failure on non-ARM? Also feels like the code signing should be done when creating bottles rather than pouring existing ones.

Verified

This commit was signed with the committer’s verified signature.
XSAM Sam Xie
…Homebrew"
@jonchang
Copy link
Contributor

Also feels like the code signing should be done when creating bottles rather than pouring existing ones.

Wouldn't relocation invalidate the signature? So it needs to be done after pouring.

@MikeMcQuaid
Copy link
Member Author

Wouldn't relocation invalidate the signature? So it needs to be done after pouring.

Good point. Regardless it shouldn't be fatal on Intel (until we figure this out or have a DSL to opt-out on specific formulae) and I still wonder whether something like code signing before bottling and then resigning after pouring only if there was an existing code signature would make sense (to avoid trying to sign things that failed to be signed during our CI process).

@MikeMcQuaid
Copy link
Member Author

@woodruffw @mistydemeo thinking about this more I think it might be easier to have a separate ruby-macho API call required for code-signing (raising exceptions on failures) that we can call in Homebrew/brew and control whether it's called or fatal for ARM/Intel on this side. That would make it easier to tweak behaviour in cases like this without needing to do a full revert (and perhaps even enable/disable code signing on Intel for e.g. gdb on other macOS versions with a DSL).

@MikeMcQuaid MikeMcQuaid merged commit 8aa6502 into master Oct 14, 2020
@MikeMcQuaid MikeMcQuaid deleted the revert-8913-dependabot/bundler/Library/Homebrew/ruby-macho-2.3.0 branch October 14, 2020 17:29
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
4 participants