Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: Print error message to stderr when not using TTY #8925

Merged
merged 2 commits into from
Oct 16, 2020

Conversation

whoiswillma
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Address #8870 / start a conversation about how to address it.

Sorry, something went wrong.

@MikeMcQuaid
Copy link
Member

Looking good so far!

  • Surface searching pull requests with a --pull-request option.

Is this mentioned in an open issue or just something you personally had a use for?

@whoiswillma
Copy link
Contributor Author

Not mentioned in the issue: I just thought it was strange that the way you had to search for PRs was by entering the name of a formula that was recently deleted.

The less ideological but more realistic answer is that I wanted brew search to throw an exception to match the behavior of brew upgrade et al., but I couldn't throw an exception then print PR search results to replicate the current functionality.

@MikeMcQuaid MikeMcQuaid merged commit c2970bd into Homebrew:master Oct 16, 2020
@MikeMcQuaid
Copy link
Member

Thanks again @whoiswillma!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants