tap-new: add option for branch name

[Rylan12]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?
• Have you successfully run brew man locally and committed any changes?

---

Allow tap-new to accept a --branch flag to specify a branch name for the new tap. Additionally, modify the CI workflows to be compatible with a custom branch name (another CI issue where the label name was missing quotes is fixed as well).

Note: I've opted to make main be the default branch name here instead of master. GitHub repositories are now created with a default branch name of main so I think it's fitting that we create new taps with a branch called main by default. This also makes uploading the new tap repository to GitHub much easier (you can just copy and paste the necessary lines if you create a new repo from the web UI) and will allow all CI to work out of the box without needing to worry about branch names changing. I think it's a good idea to start using the branch name main where we can. The rest of the Homebrew project still uses master as the default branch name, though, so I won't fight hard for this if keeping with master is desired.

[issyl0]

Works for me. Matching the default GitHub behaviour for new repo branch names makes sense. Are there any docs we need to edit that are Homebrew-specific that need to take account of this change to specify --branch=master?

[dawidd6]

Maybe better specify -b flag for git init directly?

[Rylan12]

I had it this way initially but tests failed. I think the -b flag is a new feature that isn't available in the system versions of git

[Rylan12]

Are there any docs we need to edit that are Homebrew-specific that need to take account of this change to specify --branch=master?

Good question, not sure. I'll take a look

[Rylan12]

@issyl0 I don't think there are any docs that need to be updated. We don't really reference brew tap-new anywhere except here. Think it's worth adding a note there mentioning the default branch name?

[issyl0]

Think it's worth adding a note there mentioning the default branch name?

I think it's fine to just go with the default in that case and not mention it.

[MikeMcQuaid]

Note: I've opted to make main be the default branch name here instead of master. GitHub repositories are now created with a default branch name of main so I think it's fitting that we create new taps with a branch called main by default. This also makes uploading the new tap repository to GitHub much easier (you can just copy and paste the necessary lines if you create a new repo from the web UI) and will allow all CI to work out of the box without needing to worry about branch names changing.

Makes sense to me 👍🏻

[MikeMcQuaid]

Thanks again @Rylan12!