Skip to content

Fix type error for inreplace. #8945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Fix type error for inreplace. #8945

merged 1 commit into from
Oct 19, 2020

Conversation

jonchang
Copy link
Contributor

inreplace "file.c", "a", "b" is a common idiom in formula install blocks.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
AustinAbro321 Austin Abro
`inreplace "file.c", "a", "b"` is a common idiom in
formula install blocks.
@jonchang jonchang requested a review from reitermarkus October 19, 2020 08:15
@jonchang jonchang merged commit 914483b into Homebrew:master Oct 19, 2020
@jonchang jonchang deleted the fix-type branch October 19, 2020 10:41
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants