Skip to content

Permit installation of googletest #8947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Permit installation of googletest #8947

merged 1 commit into from
Oct 19, 2020

Conversation

rleigh-codelibre
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Closes: #8935

Please see #8935 for a full description of the change. This PR removes the exclusions for gtest and gmock so that it will be possible to install google test in the future. The prohibition upon installing these systemwide is no longer in place, as detailed in the issue description.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
dywedir Vlad M.
@MikeMcQuaid
Copy link
Member

Thanks for the PR @rleigh-codelibre!

@MikeMcQuaid MikeMcQuaid merged commit 7a3c43e into Homebrew:master Oct 19, 2020
@rleigh-codelibre rleigh-codelibre deleted the 8935_permit_googletest branch October 19, 2020 14:33
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gtest and gmock are now installable systemwide
3 participants