Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared_audits: fix conditional in Bitbucket notability check #8950

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

alebcay
Copy link
Member

@alebcay alebcay commented Oct 19, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

This check currently returns an error for repositories that are notable enough (and passes on repositories that are not notable enough).

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This check currently returns an error for repositories that are
notable enough (and passes on repositories that are not notable
enough).
@alebcay alebcay force-pushed the bitbucket-audit-fix branch from ab95bc7 to 534f0e6 Compare October 19, 2020 17:29
@alebcay alebcay requested a review from reitermarkus October 19, 2020 17:44
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@reitermarkus reitermarkus merged commit 6d8978e into Homebrew:master Oct 19, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants