Add some type signatures. #8952

reitermarkus · 2020-10-19T23:10:57Z

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run brew style with your changes locally?
Have you successfully run brew tests with your changes locally?
Have you successfully run brew man locally and committed any changes?

Add signatures to PATH and UnpackStrategy::Zip.

MikeMcQuaid · 2020-10-20T10:45:42Z

Library/Homebrew/PATH.rb

 # frozen_string_literal: true

 # Represention of a `*PATH` environment variable.
 #
 # @api private
 class PATH
+  extend T::Sig


Wait, I thought these were going into RBI files for now?

Add type signatures for PATH.

a582b6e

reitermarkus requested review from issyl0 and vidusheeamoli October 19, 2020 23:10

reitermarkus force-pushed the sorbet branch 5 times, most recently from 9b21eb4 to 12585e3 Compare October 20, 2020 05:42

Add type signatures for UnpackStrategy::Zip.

ab33bc6

reitermarkus force-pushed the sorbet branch from 12585e3 to ab33bc6 Compare October 20, 2020 07:50

MikeMcQuaid approved these changes Oct 20, 2020

View reviewed changes

reitermarkus merged commit 4087c7e into Homebrew:master Oct 20, 2020

reitermarkus deleted the sorbet branch October 20, 2020 10:03

MikeMcQuaid reviewed Oct 20, 2020

View reviewed changes

BrewTestBot added the outdated label Dec 1, 2020

Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020

Provide feedback