Skip to content

bintray: warn on upload error on uploads #8970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2020
Merged

bintray: warn on upload error on uploads #8970

merged 1 commit into from
Oct 22, 2020

Conversation

jonchang
Copy link
Contributor

Previously this would only warn on errors for certain Bintray API requests like publishing. This should now also warn on error for curl POST uploads (if the appropriate flag has been passed).

cc @fxcoudert @dawidd6

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Sorry, something went wrong.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me. Will make --warn-on-error considerably more permissive but that seems to be the point.

Previously this would only warn on errors for certain Bintray API
requests like publishing. This should now also warn on error for curl
POST uploads (if the appropriate flag has been passed).
@jonchang jonchang merged commit 852affd into Homebrew:master Oct 22, 2020
@jonchang jonchang deleted the fix-skip-upload-error branch October 22, 2020 14:59
@jonchang
Copy link
Contributor Author

There's some kind of issue with the GitHub runners and testing. They would frequently fail with rubygems errors. It took probably 2-3 retries and several force pushes to get this merged.

@MikeMcQuaid
Copy link
Member

There's some kind of issue with the GitHub runners and testing. They would frequently fail with rubygems errors. It took probably 2-3 retries and several force pushes to get this merged.

@jonchang what errors and what platform? Do you have any logs you can link to and I can take a look?

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants