Skip to content

Add more license symbol functionality #8972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2020
Merged

Add more license symbol functionality #8972

merged 4 commits into from
Oct 23, 2020

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Oct 22, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Modify some license functionality to allow for more license symbols to be added as needed. Specifically, this adds the :cannot_represent symbol as discussed in Homebrew/homebrew-core#63226 (comment).

In the future, adding the symbol to the ALLOWED_LICENSE_SYMBOLS allow list should be the only change necessary to allow for more license symbols.

Sorry, something went wrong.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work again @Rylan12!

Convert forbidden licenses to a string before duplicating to have empty
strings instead of `nil`.
@Rylan12 Rylan12 merged commit c4ae961 into Homebrew:master Oct 23, 2020
@Rylan12 Rylan12 deleted the license-add-cannot-represent branch October 23, 2020 12:31
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants