Skip to content

Add support for npm 7 #8973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Conversation

diogoazevedos
Copy link
Contributor

@diogoazevedos diogoazevedos commented Oct 22, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

After upgrading npm to 7, the npm install started to fail because the dirs libexec/lib doesn't exist. On Homebrew/homebrew-core#63170 I added the mkdir_p libexec/"lib" to 2 formulas, but probably this will be necessary again for other formulas.

These lines should be removed later.

Sorry, something went wrong.

@diogoazevedos diogoazevedos force-pushed the npm-7-support branch 2 times, most recently from 97a0c0c to 120e364 Compare October 22, 2020 21:00

Verified

This commit was signed with the committer’s verified signature. The key has expired.
AustinAbro321 Austin Abro
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MikeMcQuaid MikeMcQuaid merged commit 1f6c1e9 into Homebrew:master Oct 26, 2020
@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @diogoazevedos!

@diogoazevedos diogoazevedos deleted the npm-7-support branch October 26, 2020 14:45
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants