Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove infrakit from GITHUB_PRERELEASE_ALLOWLIST as it's deprecated #8985

Merged

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Oct 25, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Sorry, something went wrong.

@fxcoudert
Copy link
Member

The allow-list ends up being to synced with formulas because it's in a different repo. Wouldn't it be better to have a way maintain this information in the same place? I.e., in a given formula, tag it with “this is a prerelease but it's okay”? That way, when we update, we can check if it's still relevant — and it gets removed when the formula is deprecated or removed.

@issyl0
Copy link
Member Author

issyl0 commented Oct 25, 2020

@fxcoudert Good point, yeah. There are other allowlists for other things to do with formulae too. We can have a think about how to handle it!

@issyl0 issyl0 merged commit de8f487 into Homebrew:master Oct 25, 2020
@issyl0 issyl0 deleted the rm-infrakit-from-prerelease-allowlist branch October 25, 2020 16:44
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 1, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants