Skip to content

Commit

Permalink
qt: rebuild without brotli linkage
Browse files Browse the repository at this point in the history
qt picked up (opportunistic) linkage with `brotli` in #74794.

See #75915.

Closes #75926.

Signed-off-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com>
Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
  • Loading branch information
carlocab authored and BrewTestBot committed Apr 26, 2021
1 parent d0bdd5d commit fa5ff69
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Formula/qt.rb
Expand Up @@ -4,7 +4,7 @@ class Qt < Formula
url "https://download.qt.io/official_releases/qt/6.0/6.0.3/single/qt-everywhere-src-6.0.3.tar.xz"
sha256 "ca4a97439443dd0b476a47b284ba772c3b1b041a9eef733e26a789490993a0e3"
license all_of: ["GFDL-1.3-only", "GPL-2.0-only", "GPL-3.0-only", "LGPL-2.1-only", "LGPL-3.0-only"]
revision 1
revision 2
head "https://code.qt.io/qt/qt5.git", branch: "dev", shallow: false

# The first-party website doesn't make version information readily available,
Expand Down Expand Up @@ -83,6 +83,7 @@ def install

-libproxy
-no-feature-relocatable
-no-feature-brotli
-system-sqlite

-no-sql-mysql
Expand Down

5 comments on commit fa5ff69

@differance1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would I get this to compile with a brew cmake or clang or whatever, rather than the Xcode ones? Might that let me get it going on high sierra?

@carlocab
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try brew install --build-from-source qt. You'll probably need to build all its dependencies from source too, though.

@differance1
Copy link

@differance1 differance1 commented on fa5ff69 May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that input, and it's cool; I know I'm out of line. Yeah, I've been doing that, but it keeps compiling using the Xcode and error-ing. Thought I'd sneak in one query in hopes someone knew a simple trick to fiddle with the .rb formulas. I've reinstalled llvm (with -build-from-source) [later: apparently not, though I think it compiled without specifically setting that switch] even though there was no indication it needed upgrading and that seemed to download some new pieces and I think [the pyqt install from source] failed in a different place after that. Seems like an old compiler that doesn't handle new types or something. But it doesn't seem to be using a brew version [(at least by my ill-informed guess)]; the failed command references Xcode SDK 10.14. Anyway, thanks for the recent backport hacking, with this and pyqt.rb and pyqt-builder.rb, it almost looked like building from source was going to start working [for me]. :-)

@carlocab
Copy link
Member Author

@carlocab carlocab commented on fa5ff69 May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you were able to install the llvm formula (which would need to be built from source...), then you can try

brew install --build-from-source --cc=llvm_clang qt

@differance1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Above and beyond. Your tip lets me get a sense I'm not entirely off track and how niggling at things can be done. I just checked my llvm reinstall command and no, I didn't do it from source, but the output distinctly looked like it was compiling anyway, brought in some other bits of code and (pretty sure) it had the ./configure, make or ninja steps. I will try this and probably a lot of things now, first without doing the llvm again, then with the llvm building from source. After that, I now see better how I might try different compilers. Also, first with pyqt, letting it pull in qt as a dependency. Thanks again! :-)

Please sign in to comment.