Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 18.1.0 #100691

Closed
wants to merge 2 commits into from
Closed

node 18.1.0 #100691

wants to merge 2 commits into from

Conversation

bevanjkay
Copy link
Member

@bevanjkay bevanjkay commented May 3, 2022

Created by brew bump


Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` long build Needs CI-long-timeout labels May 3, 2022
@derrabus
Copy link
Contributor

derrabus commented May 3, 2022

npm needs to be bumped to 8.8.0, see nodejs/node#42886

@branchvincent branchvincent added CI-long-timeout Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels May 3, 2022
@bevanjkay
Copy link
Member Author

Thanks @branchvincent - sorry I thought the PR hadn't gone through due to a duplicate.

@cho-m cho-m removed the CI-long-timeout Use longer GitHub Actions CI timeout. label May 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label May 7, 2022
@github-actions github-actions bot closed this May 8, 2022
@derrabus
Copy link
Contributor

derrabus commented May 9, 2022

This is unfortunate. Can we please reopen the PR? Was there a CI failure that blocked bumping the formula?

@branchvincent branchvincent reopened this May 9, 2022
@branchvincent branchvincent added help wanted Task(s) needing PRs from the community or maintainers in progress Stale bot should stay away and removed stale No recent activity labels May 9, 2022
@derrabus
Copy link
Contributor

derrabus commented May 9, 2022

Error: PR requires the CI-long-timeout label but it is not set!
Error: If the longer timeout is not required, remove the "long build" label.
Error: Otherwise, add the "CI-long-timeout" label.
Error: No more than 2 PRs at a time may use "CI-long-timeout".

Can you please add the CI-long-timeout label, @branchvincent?

@bevanjkay
Copy link
Member Author

bevanjkay commented May 9, 2022

@derrabus There is only a limited amount of long-timeout slots available, so CI cannot be restarted at the moment.
The failures from the previous run should be addressed first anyway - https://github.com/Homebrew/homebrew-core/actions/runs/2266546607

@derrabus
Copy link
Contributor

derrabus commented May 9, 2022

Thanks, those failures were the piece of information I was looking for. 🙂

@branchvincent
Copy link
Member

branchvincent commented May 9, 2022

To summarize those logs, all runners encountered the same two issues:

==> /usr/local/Cellar/bash-language-server/2.1.0/bin/bash-language-server start
  (node:58791) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
  (Use `node --trace-warnings ...` to show where the warning was created)
  node:internal/deps/undici/undici:4816
              throw new TypeError("Failed to parse URL from " + input, { cause: err });
                    ^
  
  TypeError: Failed to parse URL from /usr/local/Cellar/bash-language-server/2.1.0/libexec/lib/node_modules/bash-language-server/node_modules/web-tree-sitter/tree-sitter.wasm
==> node test.js
  (node:79957) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
  (Use `node --trace-warnings ...` to show where the warning was created)
  /private/tmp/emscripten-test-20220504-77343-3id2oy/test.js:146
        throw ex;
        ^
  
  TypeError: Failed to parse URL from /private/tmp/emscripten-test-20220504-77343-3id2oy/test.wasm

@bevanjkay
Copy link
Member Author

Seems to have been tracked upstream

nodejs/node#42701 (comment)

@bevanjkay
Copy link
Member Author

The test for emscripten will pass with the flag --no-experimental-fetch - emscripten-core/emscripten#16913

@bevanjkay
Copy link
Member Author

#101576 update should fix bash-language-server

@bevanjkay
Copy link
Member Author

@branchvincent Do we usually fix the tests in a separate PR? I think this should be green now.

@bevanjkay bevanjkay requested review from branchvincent and removed request for branchvincent May 16, 2022 13:28
@bevanjkay bevanjkay requested a review from chenrui333 May 17, 2022 02:46
@faradaytrs
Copy link

Could we merge this?

@SMillerDev SMillerDev added the CI-long-timeout Use longer GitHub Actions CI timeout. label May 17, 2022
@bevanjkay
Copy link
Member Author

Still the same test error on bash-language-server, was supposed to be fixed in version 3.0.1 but seems that it hasn't been.

@derrabus
Copy link
Contributor

node 18.2.0 has been released, bumping NPM to 8.9.0: https://github.com/nodejs/node/releases/tag/v18.2.0

@chenrui333
Copy link
Member

maybe let's merge this one and fix the failures and then start 18.2.0 journey.

@alebcay alebcay removed the CI-long-timeout Use longer GitHub Actions CI timeout. label May 17, 2022
@BrewTestBot
Copy link
Member

:shipit: @chenrui333 has triggered a merge.

@chenrui333
Copy link
Member

only bash-language-server failed on all builds, I will do a merge and follow up to see if that is reproducible.

@chenrui333 chenrui333 mentioned this pull request May 17, 2022
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. help wanted Task(s) needing PRs from the community or maintainers in progress Stale bot should stay away long build Needs CI-long-timeout outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants