Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opencv 4.5.4 #90315

Closed
wants to merge 1 commit into from
Closed

opencv 4.5.4 #90315

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 2, 2021 •
edited

Created with brew bump-formula-pr.

resource blocks may require updates.

Recapitulates #87064 and #89948

@BrewTestBot BrewTestBot added automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` python Python use is a significant feature of the PR or issue labels Dec 2, 2021
@carlocab carlocab added test failure CI fails while running the test-do block help wanted Task(s) needing PRs from the community or maintainers labels Dec 3, 2021
@cclauss
Copy link
Contributor Author

cclauss commented Dec 3, 2021 •
edited

@alalek Can you or someone on your team please help us to land the current release of OpenCV on homebrew?

This is our third attempt after #87064 and #89948 but we have not yet found the secret sauce.

@carlocab carlocab changed the title Bump opencv 4.5.4 opencv 4.5.4 Dec 3, 2021
@alalek
Copy link

alalek commented Dec 3, 2021

No idea on which OpenCV error should we take a look. OpenCV 4.5.3->4.5.4 update doesn't bring new dependencies.

There are reported several Apple M1 issues from other packages.
Changing with just adding new empty line probably would emit the same errors (IMO, it is Homebrew infrastructure issue).

Could we disable M1 platform or some dependencies which are not ready for M1 in OpenCV formula to unblock upgrade?

@SMillerDev
Copy link
Member

Could we disable M1 platform or some dependencies which are not ready for M1 in OpenCV formula to unblock upgrade?

Well, it works for the current version so that would break anything using OpenCV for anyone on ARM.

@cclauss the compilation doesn't fail for OpenCV so getting their developers to help won't add much. We need to fix the formulae that actually break.

@alalek
Copy link

alalek commented Dec 4, 2021

Well, it works for the current version

Open a new PR with adding new empty line into opencv.rb and ensure that Homebrew QA fails.
So it doesn't work actually. It just doesn't launched.

Infrastructure problem should be fixed by dropping of unmaintained dependencies: #90371

@cclauss
Copy link
Contributor Author

cclauss commented Dec 6, 2021

The builds on M1 Macs work fine but the builds on Intel Macs timeout.

@SMillerDev SMillerDev added the CI-long-timeout Use longer GitHub Actions CI timeout. label Dec 6, 2021
@cclauss
Copy link
Contributor Author

cclauss commented Dec 6, 2021

Nice!

SMillerDev
SMillerDev previously approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cclauss ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@cclauss
Copy link
Contributor Author

cclauss commented Dec 7, 2021

Will the bots merge a passing PR that has a label: test failure?

@SMillerDev
Copy link
Member

No, but the automerge-skip label does. Try squashing all commits into one.

@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Dec 7, 2021
@SMillerDev SMillerDev removed help wanted Task(s) needing PRs from the community or maintainers test failure CI fails while running the test-do block labels Dec 8, 2021
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Jan 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-long-timeout Use longer GitHub Actions CI timeout. outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cclauss @alalek @SMillerDev @BrewTestBot @carlocab