CALL-3878: Migrate to TS and add CJS & ESM Builds #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create incoming call started method to test inbound calling
* Refactor constants * Refactor version constant * 0.1.6-alpha.0 * Remove sdkVersion prop from initialized event * 0.1.6-alpha.1 * Introduce inbound calling availability events * Test new events * Configure prettier and format the demo-minimal-js html. Improve accessibility and SEO. * Use semantic html and style buttons * Refactor switch case into onclick methods and remove logic that waits for DOM content loaded since we are using defer to load the JS * Rename id * Specify encoding * Match SDK event name * sort props * Initialize as logged out * Add user availability events * Prevent window overflow * Allow user to change availability during a call. * disable availability buttons during a call. * 0.1.7-alpha.0 * Use new alpha version
Create event handlers for create_engagement_succeeded and create_engagement_failed
* Initialize SDK on ready event * Save userAvailable state in the demo widget * Allow user to start an incoming call asynchronously for testing (#146)
* Initialize SDK on ready event * Save userAvailable state in the demo widget * Allow user to start an incoming call asynchronously for testing (#146) * Revert "Allow user to start an incoming call asynchronously for testing (#146)" This reverts commit 9800470. --------- Co-authored-by: Esme Ling <esmelingyr@gmail.com> Co-authored-by: Esme <23175119+esme@users.noreply.github.com>
* Add events for caller id matching * Add caller id match payload * Add debugMessageType argument to logging * Add incomingCall event handler to README * Log last sync event
* Add support for inbound calling to react demo app * Add unit tests for Incoming Screen * Unit tests * Fix useCti hook to store incomingNumber * Feedback fixes # 1 * Feedback fixes #2 * Feedback fixes
* Send navigate_to_record event when we receive an existing call id * Fix console debug message const * Navigate to record page in the react demo app (#165) * Update README with instructions for redirect * 0.2.1-alpha.3 * Use next tag of SDK
…166) * React Demo App: Set incoming number and contact info in localstorage on redirect * feedback fixes
* switch case lost its case to dictionary * Handle NAVIGATE_TO_RECORD_FAILED * Add event handler to demos * Remove unused message handler
|
|
These changes mean we are coupling our inbound calling release with the TS migration. Here are a few concerns:
|
Yeah these are valid concerns. We could do the following to mitigate risk:
|
I agree we should split this up into multiple PRs and incrementally migrate. I doubt we would need to duplicate files as we are exporting from index.js. So, customers always import from the package which points to index file. Internal structure shouldnt cause problem. I was not aware of realistic date for inbound GA. But, from this PR, we can split up our story into tasks and do incremental migration release. |
Ideally breaking change warrants for major version release. But, our timeline might not be helpful here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira Ticket: CALL-3878
Merge Checklist
BRAVE Checklist