Reject unrecognized flags that start with -Xep

Fixes google#1275 PiperOrigin-RevId: 350823043
HubSpot · Jan 15, 2021 · 50f7ecd · 50f7ecd
1 parent 9880adc
commit 50f7ecd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/check_api/src/main/java/com/google/errorprone/ErrorProneOptions.java b/check_api/src/main/java/com/google/errorprone/ErrorProneOptions.java
@@ -45,6 +45,7 @@
  */
 public class ErrorProneOptions {
 
+  private static final String PREFIX = "-Xep";
   private static final String SEVERITY_PREFIX = "-Xep:";
   private static final String PATCH_CHECKS_PREFIX = "-XepPatchChecks:";
   private static final String PATCH_OUTPUT_LOCATION = "-XepPatchLocation:";
@@ -461,6 +462,9 @@ public static ErrorProneOptions processArgs(Iterable<String> args) {
             builder.setExcludedPattern(Pattern.compile(pathRegex));
 
           } else {
+            if (arg.startsWith(PREFIX)) {
+              throw new InvalidCommandLineOptionException("invalid flag: " + arg);
+            }
             remainingArgs.add(arg);
           }
       }

diff --git a/check_api/src/test/java/com/google/errorprone/ErrorProneOptionsTest.java b/check_api/src/test/java/com/google/errorprone/ErrorProneOptionsTest.java
@@ -269,4 +269,11 @@ public void importOrder_androidStaticLast() {
     assertThat(options.patchingOptions().importOrganizer())
         .isSameInstanceAs(ImportOrganizer.ANDROID_STATIC_LAST_ORGANIZER);
   }
+
+  @Test
+  public void noSuchXepFlag() {
+    assertThrows(
+        InvalidCommandLineOptionException.class,
+        () -> ErrorProneOptions.processArgs(new String[] {"-XepNoSuchFlag"}));
+  }
 }