Catch throwable instead of exception #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the OP suggests that OutOfMemory errors were not propagating; perhaps we do want to be selective in what we catch here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They changed this on us in c391bae. They seem to be advocating for allowing some errors, such as OOMs to bubble up, which seems reasonable.
Any thoughts on if we want to do something smart here? We could just add
LinkageErrorto the catch as its subclasses are what keep biting us. Or we could just go withThrowablehere like we currently do elsewhere and move on.@Xcelled @suruuK @jaredstehler @PtrTeixeira @ggs5427