Support writing longs as strings (opt-in) #98
Conversation
|
No comment on this particular PR, but it might be worth filing an issue for |
|
@cowtowncoder Done: FasterXML/jackson-core#1044. Since the limitation doesn't seem to be applicable to YAML, I guess this would be a Having done that, I'd like the present request to be considered in its own right, as the flexibility requested here is specific to the serialization of protocol buffer messages. |
`jackson-datatype-protobuf` is a missing link in the Jackson ecosystem, but it doesn't currently provide a way to write 64-bit integers using their canonical representation, which poses a problem for strict downstream parsers given the limitation of the maximum value to [2^53 - 1](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/MAX_SAFE_INTEGER) ([alt](https://developers.google.com/discovery/v1/type-format)) in JavaScript, whereas this value is for instance [2^63 - 1](https://docs.oracle.com/javase/tutorial/java/nutsandbolts/datatypes.html) in Java. The change proposed here is to provide users who need it with an option to activate this canonical representation, without altering the existing default behavior.
rdesgroppes
force-pushed
the
support-writing-longs-as-strings
branch
from
b797d1f
to
9378d7c
Compare
|
Thank you @rdesgroppes. Agreed on all points. |
|
Hi @jhaber! May I kindly request a review? |
|
@sankala-dremio or @stevie400, could you help there? |
|
👋 I was on vacation, sorry for the delay. Support for writing longs as strings has been a long-standing feature request, as this is the canonical representation according to protobuf spec. However, as part of implementing this I noticed that we're not serializing/deserializing unsigned numbers properly. I'm hoping to tackle that first, and layer the string stuff on top |
@jhaber is there anything I could do to help, then? |
|
I opened #101 yesterday, I think it should address both issues |
|
Cool! |
|
Yup, feel free to close. I'm planning to cut a release soon |
I just gave a try with a locally built jar from the master branch and found out that |
|
Thanks for flagging, I'll try to reproduce and fix the issue |
I filed #102 to track that. |
jackson-datatype-protobufis a missing link in the Jackson ecosystem, but it doesn't currently provide a way to write 64-bit integers using their canonical representation, which poses a problem for strict downstream parsers given the limitation of the maximum value to 2^53 - 1 (alt) in JavaScript, whereas this value is for instance 2^63 - 1 in Java.The change proposed here is to provide users who need it with an option to activate this canonical representation, without altering the existing default behavior.
Addresses part of #76.
Supersedes #77.