Support exact-matching on FormData bodies #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylekthompson
requested review from
doxavore,
onachassi,
TAGraves,
mcgloneleviHB,
ntaylor89,
shanemacbride and
vchan8084
If people feel strongly, I can do it anyway, though |
mcgloneleviHB
approved these changes
Nov 8, 2021
TAGraves
reviewed
Nov 8, 2021
| @@ -72,6 +72,7 @@ | |||
| "eslint-config-origami-component": "1.0.0", | |||
| "eslint-config-prettier": "^2.9.0", | |||
| "eslint-plugin-prettier": "^2.6.1", | |||
| "form-data": "^2.3.3", | |||
There was a problem hiding this comment.
Should there be a change to package-lock.json with this?
There was a problem hiding this comment.
It's already included as a dependency of request
TAGraves
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we attempt to get wheresrhys#622 merged, I'd like to maintain this fork of
fetch-mockinternally so that we can keep moving on some other work we have going on.Since there hasn't been a
fetch-mockrelease in a year, I assume it's pretty stable and this won't become an issue, but we should get off the fork as soon as possible (so let's keep an eye on it).Note: I don't want to set up CI for this since it should be short-lived, but this all passed locally 馃槄