feat: LEAP-883: Custom Scripts #5879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
# Conflicts: # web/dist/apps/labelstudio/version.json # web/dist/libs/datamanager/version.json # web/dist/libs/editor/version.json
Add ability to set id on div rendered by View to make it easy to use with for example custom styles
# Conflicts: # web/dist/apps/labelstudio/version.json # web/dist/libs/datamanager/main.js # web/dist/libs/datamanager/main.js.map # web/dist/libs/datamanager/version.json # web/dist/libs/editor/version.json
|
/git merge
|
This PR improves the way of saving annotations (submit and update) with allowing to prevent submitting in some cases such as validation. - feat: LEAP-1060: Add event to allow control annotations submitting - Fix behavior in case of absence of event listeners - Fix submitting without event handlers for beforeSaveAnnotation ### PR fulfills these requirements - [ ] Tests for the changes have been added/updated (for bug fixes/features) - [ ] Docs have been added/updated (for bug fixes/features) - [x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.) - [x] Self-reviewed and ran all changes on a local instance (for bug fixes/features) #### Change has impacts in these area(s) _(check all that apply)_ - [ ] Product design - [ ] Backend (Database) - [ ] Backend (API) - [x] Frontend ### Describe the reason for change A missed useful event. ### Does this PR introduce a breaking change? _(check only one)_ - [ ] Yes, and covered entirely by feature flag(s) - [ ] Yes, and covered partially by feature flag(s) - [x] No - [ ] Not sure (briefly explain the situation below) ### What level of testing was included in the change? _(check all that apply)_ - [ ] e2e - [ ] integration - [ ] unit ### Which logical domain(s) does this change affect? `Annotation`, `Validation` --------- Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com> Co-authored-by: hlomzik <hlomzik@gmail.com>
# Conflicts: # web/dist/apps/labelstudio/version.json # web/dist/libs/datamanager/main.js # web/dist/libs/datamanager/version.json # web/dist/libs/editor/main.js # web/dist/libs/editor/main.js.map # web/dist/libs/editor/version.json
…labs/label-studio into fb-leap-883/custom-scripts
hlomzik
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idAttrparameter intoViewtag to make easier to work with custom styles and so onlsfInitandbeforeLsfDestroyevents into data manager for better control of the life cyclePR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
Does this PR introduce a breaking change?
What level of testing was included in the change?
Which logical domain(s) does this change affect?
DataManager,View