-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] For iOS13 do not use automatic
modal presentation style for segue
#617
base: master
Are you sure you want to change the base?
Conversation
Generated by 🚫 Danger |
I do think you have the right approach, won't we have issue with all the other segue overriden? I don't remember exactly how it was working. |
Because Segue doesn't support If the current Segues only support fullscreen, shall we change the method |
I can rename but I will make my mode less intrusive, so it is not always fullscreen Set |
automatic
modal presentation style for segueautomatic
modal presentation style for segue
I has made my code more restrictive to fix the segue but! I see that fixing the segue is not the solution Maybe some code to fix into UIPresentationController override or delegates |
In Xcode 11.3, I had to apply the Presentation fullscreen setting onto specific View Controllers in order for the segue to complete successfully. Making sure to use the custom segues from IBAnimatable now works again. |
Segues set using storyboards, such as
PresentSlideSegue
, seem to failed to presentI see that iOS 13 add new navigation stack and
automatic
modal presentation styleBefore
fullscreen
(=0) was the default one (If I debug)I am wondering If IBAnimatable must force to fullscreen the modal presentation style like I do in my PR when the segue is used (to make it work)
or document and say you must select Presentation: Full Screen (or current context if previous was also full screen etc...)
(xcode 11 screenshot, must not be available in xcode 10)