Fix LifecycleService status #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The status colour and message were being retrieved from the Ready condition, the status column was being retreived from the "Lifecycle Service Ready" condition. The Ready has been available since 3.3, "Lifecycle Service Ready" will be removed in 3.5 as k8s.io condition type does not allow spaces in condition types. The documentation states that this plugin supports CP4WAIOps v3.3 and above so I have not left support for "Lifecycle Service Ready". Signed-off-by: Nick Banyard <banyard@uk.ibm.com>
banyard-ibm
force-pushed
the
banyard/lifecycle-status
branch
from
42653e5
to
c83689c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status colour and message were being retrieved from the Ready condition,
the status column was being retreived from the "Lifecycle Service Ready" condition.
The Ready has been available since 3.3, "Lifecycle Service Ready" will be removed in 3.5
as k8s.io condition type does not allow spaces in condition types.
The documentation states that this plugin supports CP4WAIOps v3.3 and
above so I have not left support for "Lifecycle Service Ready".