build(deps): bump axios from 1.2.1 to 1.4.0 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojito317
force-pushed
the
experiment-with-new-axios
branch
from
1151833
to
5ef5500
Compare
Signed-off-by: Ildiko Eigel <ildiko.eigel@ibm.com>
mojito317
force-pushed
the
experiment-with-new-axios
branch
from
5ef5500
to
5b4304b
Compare
mojito317
changed the title
|
Should we also bump our version of retry-axios to the latest (3.0.0, currently we're at 2.6.0). Even 3.0.0 is about a year old. |
Worth considering but IIRC we've run into a good amount of trouble trying to update that dependency, which is the reason it's so old. I think we should look into updating it but that investigation need not hold up this PR |
|
🎉 This PR is included in version 4.0.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to bump
axiosfrom1.2.1to1.4.0. There was a type change in axios/axios#5486 that was applied in1.2.4, so the request interceptor getsInternalAxiosRequestConfigconfig instead of the previousAxiosRequestConfig.Checklist
npm testpasses (tip:npm run lint-fixcan correct most style issues)