Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Set per-test timeout #301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test: Set per-test timeout #301

wants to merge 1 commit into from

Conversation

abmusse
Copy link
Member

@abmusse abmusse commented Jul 18, 2020 •
edited

The per test timeout value was determined by doubling the average runtime for each test listed in #300 (comment).

For the hooks that check if an object exists I've disabled timeout at the hook level. https://mochajs.org/#hook-level

@abmusse abmusse requested a review from kadler July 20, 2020 16:16
@abmusse abmusse marked this pull request as ready for review July 20, 2020 16:16
@abmusse abmusse added keep-open Exempts stale action from auto closing the issue/pr. and removed keep-open Exempts stale action from auto closing the issue/pr. labels Aug 13, 2020
@github-actions
Copy link

👋 Hi! This pull request has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@github-actions github-actions bot added the stale label Sep 13, 2020
@abmusse abmusse added the keep-open Exempts stale action from auto closing the issue/pr. label Sep 16, 2020
@github-actions github-actions bot closed this Oct 6, 2020
@kadler kadler removed the stale label Oct 6, 2020
@kadler kadler reopened this Oct 6, 2020
@abmusse abmusse linked an issue Oct 21, 2020 that may be closed by this pull request
Set per-test timeout values #198
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadler kadler Awaiting requested review from kadler

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
keep-open Exempts stale action from auto closing the issue/pr.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set per-test timeout values
2 participants
@abmusse @kadler