Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interaction flow #25

Merged
merged 5 commits into from
Jan 28, 2020
Merged

Interaction flow #25

merged 5 commits into from
Jan 28, 2020

Conversation

barlock
Copy link
Contributor

@barlock barlock commented Jan 10, 2020

Related Issue
Supports #5

Related PRs
deps #24

What does this PR do?
Creates a pattern for bolt apps that utilize state shared across a set of interactions vs channels

Description of Changes
New package, tests, fun.

What gif most accurately describes how I feel towards this PR?

@barlock barlock marked this pull request as ready for review January 10, 2020 20:22
tteltrab
tteltrab previously requested changes Jan 13, 2020
View reviewed changes
Copy link
Collaborator

@tteltrab tteltrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a lot going on here - looks mostly good, first review/round of comments. wanted to get some feedback up.

packages/bolt-interactions/src/interaction-flow.spec.ts Show resolved Hide resolved
packages/bolt-interactions/src/interaction-flow.ts Outdated Show resolved Hide resolved
packages/bolt-interactions/src/interaction-flow.ts Outdated Show resolved Hide resolved
packages/bolt-interactions/src/interaction-flow.ts Outdated Show resolved Hide resolved
packages/bolt-interactions/src/interaction-flow.ts Outdated Show resolved Hide resolved
packages/bolt-interactions/src/interaction-flow.ts Outdated Show resolved Hide resolved
packages/bolt-interactions/src/interaction-flow.spec.ts Outdated Show resolved Hide resolved
packages/bolt-interactions/__mocks__/@slack/web-api.ts Show resolved Hide resolved
packages/bolt-interactions/src/types.d.ts Outdated Show resolved Hide resolved
packages/bolt-interactions/src/types.d.ts Outdated Show resolved Hide resolved
@barlock barlock force-pushed the interaction-flow branch 2 times, most recently from 718aafb to 1fa975b Compare January 13, 2020 19:42
tteltrab
tteltrab requested changes Jan 28, 2020
View reviewed changes
Copy link
Collaborator

@tteltrab tteltrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some typo/clarity suggestions, also a question here and there.

packages/bolt-interactions/README.md Outdated Show resolved Hide resolved
packages/bolt-interactions/README.md Outdated Show resolved Hide resolved
packages/bolt-interactions/README.md Outdated Show resolved Hide resolved
packages/bolt-interactions/README.md Show resolved Hide resolved
packages/bolt-interactions/README.md Outdated Show resolved Hide resolved
packages/bolt-interactions/README.md Outdated Show resolved Hide resolved
packages/bolt-interactions/README.md Show resolved Hide resolved
packages/bolt-interactions/src/interaction-flow.spec.ts Show resolved Hide resolved
packages/bolt-interactions/src/types/interaction.d.ts Outdated Show resolved Hide resolved
packages/bolt-interactions/src/types/interaction.d.ts Outdated Show resolved Hide resolved
Michael Barlock and others added 3 commits January 28, 2020 16:51
@barlock
Copy link
Contributor Author

barlock commented Jan 28, 2020 •
edited

Back at'cha force pushed b/c #29 new commits are c6c12ff e4a6051

tteltrab
tteltrab reviewed Jan 28, 2020
View reviewed changes
Copy link
Collaborator

@tteltrab tteltrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow up comments

packages/bolt-interactions/README.md Outdated Show resolved Hide resolved
packages/bolt-interactions/README.md Show resolved Hide resolved
packages/bolt-interactions/src/interaction-flow.spec.ts Show resolved Hide resolved
tteltrab
tteltrab approved these changes Jan 28, 2020
View reviewed changes
Copy link
Collaborator

@tteltrab tteltrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 :shipit:

@tteltrab tteltrab merged commit 6db0466 into master Jan 28, 2020
@tteltrab tteltrab deleted the interaction-flow branch January 28, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tteltrab tteltrab tteltrab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@barlock @tteltrab