Add more irregular words #25
Conversation
lib/inflections/en.php
Outdated
| @@ -39,6 +39,9 @@ | |||
| ->plural('/^(ox)$/i', '\1en') | |||
| ->plural('/^(oxen)$/i', '\1') | |||
| ->plural('/(quiz)$/i', '\1zes') | |||
| ->plural('/^is$/', 'are') | |||
There was a problem hiding this comment.
is, was, has are verbs, not nouns. Please remove them.
There was a problem hiding this comment.
@olvlvl I realise they are verbs, but they are quite useful when showing notifications in a website and you have a verb based on a subject which could be a number of items of 0, 1 or more than 1.
1 product was added to your cart
2 products were added to your cart
I'd use an inflector here on both product/products and was/were.
|
Thanks for your contribution! I left a comment, it should fix the issues. I'm in an hackathon until Saturday. If the problem persist I'll have a look next week. |
|
@olvlvl I don't get why this would break the tests as I have added |
|
Please rebase. |
✅ Done. |
| ->irregular('leaf', 'leaves') | ||
| ->irregular('loaf', 'loaves') | ||
| ->irregular('man', 'men') | ||
| ->irregular('move', 'moves') | ||
| ->irregular('nucleus', 'nuclei') | ||
| ->irregular('octopus', 'octopuses') |
Any help with the tests is appreciated!