Fix singular for "canoes" #30

timkelty · 2018-11-30T15:49:13Z

No description provided.

olvlvl · 2018-12-01T13:49:59Z

Hi @timkelty, thanks for the patch. Do you mind defining this using ->irregular()? It does't look like a rule that can be applied to many things, and it's breaking volcano:

-'volcano'
+'volcanoe'

Also, please add it to the test cases.

timkelty · 2018-12-03T14:58:08Z

@olvlvl there are a few others (I think shoe is already in there):

toes
canoes
(snow|horse)shoes
woes
foes
hoes
does (as in multiple female deer)
schmoes 😆

olvlvl · 2018-12-03T20:10:49Z

I'm reading this article: https://en.wikipedia.org/wiki/English_plurals and it seems adding -es to word ending with o should be the default inflection. Adding only -s is for Italian stuff such as piano. English is so complicated :D

Fix singular for "canoes"

d67413a

olvlvl force-pushed the master branch from ec9d5db to 4dbefb8 Compare July 16, 2021 23:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix singular for "canoes" #30

Fix singular for "canoes" #30

timkelty commented Nov 30, 2018

olvlvl commented Dec 1, 2018 •

edited

timkelty commented Dec 3, 2018 •

edited

olvlvl commented Dec 3, 2018 •

edited

Fix singular for "canoes" #30

Are you sure you want to change the base?

Fix singular for "canoes" #30

Conversation

timkelty commented Nov 30, 2018

olvlvl commented Dec 1, 2018 • edited

timkelty commented Dec 3, 2018 • edited

olvlvl commented Dec 3, 2018 • edited

olvlvl commented Dec 1, 2018 •

edited

timkelty commented Dec 3, 2018 •

edited

olvlvl commented Dec 3, 2018 •

edited