Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: use fine-grained lodash-imports #21

Merged
merged 1 commit into from May 19, 2022
Merged

Maintenance: use fine-grained lodash-imports #21

merged 1 commit into from May 19, 2022

Commits on May 18, 2022

  1. Maintenance: use fine-grained lodash-imports 

    Lodash is a huge and chunky module. If we directly specify which methods we need from it, we can avoid a bit of the always-keep-it-up-to-date treadmill.

Further investigation could be done to see if we really even need the clone/isEqual methods from lodash, but at least with this PR change we put a soft fence around it to keep from panicking if lodash has security incidents.

Not a big deal if you don't want to drop it, since jest#core still needs it, but I thought I'd provide a PR
    @fbartho
    fbartho committed May 18, 2022
    Copy the full SHA
    c5eb875 View commit details
    Browse the repository at this point in the history