Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vitest 0.16+ #3

Merged
merged 5 commits into from Jul 7, 2022
Merged

Conversation

jasikpark
Copy link
Contributor

Fixes #2

This upgrades to vitest 0.17.0, fixes the SpyFunction type and removes the usage of done() callbacks in favor of promises in api.test.js (vitest was complaining)

@jasikpark jasikpark changed the title Jasikpark/update-vitest-2 Update vitest to 0.17.0 / fix breakages Jul 6, 2022
@IanVS
Copy link
Owner

IanVS commented Jul 6, 2022

Hmmmm, it looks like Mock is the replacement for SpyInstanceFn: vitest-dev/vitest#1525 (comment). Mind updating that here?

Also, I think we should add a peerDependencies on vitest >= 0.16.0.

@IanVS IanVS added the breaking label Jul 6, 2022
@jasikpark
Copy link
Contributor Author

done

@IanVS IanVS changed the title Update vitest to 0.17.0 / fix breakages Support vitest 0.16+ Jul 7, 2022
@IanVS IanVS merged commit 31dabb5 into IanVS:main Jul 7, 2022
@jasikpark jasikpark deleted the jasikpark/update-vitest-2 branch July 7, 2022 16:50
@jasikpark
Copy link
Contributor Author

Oops this needs to have a peer dependency of > 0.16 not 0.16 - 0.17

@IanVS
Copy link
Owner

IanVS commented Jul 7, 2022

Fixed in 0.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update vitest
2 participants