Move Windows code inside the acacia namespace #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spectranaut
reviewed
Apr 17, 2024
lib/ia2/acacia_ia2.i
Outdated
| IANode findRootIANodeForName(const std::string& name, const int pid = 0); | ||
| IANode findRootIANodeForPID(const int pid); | ||
| %rename(findRootIANodeForPID) acacia::findRootIANodeForPID; | ||
| %rename(findRootIANodeForName) acacia::findRootIANodeForName; |
There was a problem hiding this comment.
hmm do we need this? I think we don't!
The previous two lines were just in here because I didn't want to include all of the functions in the win_utils file. Now these functions are in ia_node.h I think it's fine.
There was a problem hiding this comment.
I can't build on Windows right now, but I'll check this later once I get it working again :)
spectranaut
force-pushed
the
namespace-win
branch
from
59032c8
to
a29bdbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.