Fix bug when moving large windows #1169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user tries to move a large window (3x size), it can become stuck at one extreme of the 3D environment. The underlying cause seems to be a bug in how we compute the movement of the pointer in extreme cases when the window widget is too large and is positioned on a cylinder. This bug is quite hard to pin down and only seems to happen when trying to move a large window, so for the time being the fix is to restrict the range of movement to the width of one default window.
|
The bug can be reproduced by these steps:
trim.7D649B8D-CD7B-4723-8E68-06613995E77F.MOV |
HollowMan6
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user tries to move a large window (3x size), it can become stuck at one extreme of the 3D environment.
The underlying cause seems to be a bug in how we compute the movement of the pointer in extreme cases when the window widget is too large and is positioned on a cylinder.
This bug is quite hard to pin down and only seems to happen when trying to move a large window, so for the time being this PR simply limits the range of movement for windows.