Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vision Glass] UI to realign controller on startup #1388

Merged
merged 1 commit into from May 16, 2024

Conversation

felipeerias
Copy link
Contributor

@felipeerias felipeerias commented Apr 30, 2024

Display a dialog informing the user that it is necessary to point the phone straight ahead to set up the controller.

Clicking the realign button on it will re-calibrate the controller and close the dialog.

A similar dialog is displayed on the VR environment.

Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good but I though you were going to add a dialog to the virtual world and not to the phone UI. Something similar to the privacy dialog, something that users will see no matter what. The UI in the phone could be potentially completely overlooked. I'd like to know your opinion about that.

@felipeerias felipeerias changed the title UI to realign controller on startup [Vision Glass] UI to realign controller on startup May 8, 2024
@felipeerias felipeerias force-pushed the felipeerias/vg-realign-start branch from 924d654 to 782678e Compare May 13, 2024 01:18
Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code doesn't look bad but I think it has some behavioural and aesthetic issues issues issues

  1. the font in the dialog is blurry, I guess because it has some shadow but it's difficult to read
  2. the dialog does nothing until you click, so perhaps we should add something like "and click to calibrate" ?
  3. the dialog is not autoclosed after 5s, it needs 10-15s sometimes and the calibration is not done

Apart from that we've talked about adding some visual indication in VR. As far as I see there is nothing about that yet.

@felipeerias felipeerias force-pushed the felipeerias/vg-realign-start branch 6 times, most recently from 005e47a to ed2347a Compare May 15, 2024 01:41
@felipeerias felipeerias requested a review from svillar May 15, 2024 01:43
@felipeerias felipeerias force-pushed the felipeerias/vg-realign-start branch 2 times, most recently from 1f2f8f9 to 4a9379f Compare May 15, 2024 05:10
Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The visual indication looks great. However I think we should disable the autoclose and force the user to click on the button. There is no time to read the text and do the action unless you're a pro user. So I think we should remove the autodismiss, and then we could land it.

@felipeerias felipeerias force-pushed the felipeerias/vg-realign-start branch from 4a9379f to d8fa5ed Compare May 15, 2024 09:05
@felipeerias felipeerias requested a review from svillar May 15, 2024 09:06
Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK so some more comments, sorry for the back and forth. This is what I experience now

  1. the phone UI keeps dissapearing
  2. the OK button in the glasses dialog maybe could be removed, otherwise users will try to click on it with an uncalibrated controller
  3. we should probably describe a bit better what we expect from the user. The current text is good but we should also mention that once the phone is aligned they need to tap on the phone
  4. last but not least calibration does not happen once the dialog is closed, you need to tap on the calibration button again.

@svillar
Copy link
Member

svillar commented May 15, 2024

OK so some more comments, sorry for the back and forth. This is what I experience now

1. the phone UI keeps dissapearing

2. the OK button in the glasses dialog maybe could be removed, otherwise users will try to click on it with an uncalibrated controller

3. we should probably describe a bit better what we expect from the user. The current text is good but we should also mention that once the phone is aligned they need to tap on the phone

4. last but not least calibration does not happen once the dialog is closed, you need to tap on the calibration button again.

BTW just to clarify, I think 4. does not require any action from you. I think we can fix it with my changes in #1421

@felipeerias felipeerias force-pushed the felipeerias/vg-realign-start branch from 77f3207 to 0470785 Compare May 16, 2024 02:07
Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

I'd suggest to add a text like the one I added to ask users to click on the align widget

Display a dialog informing the user that it is necessary to
point the phone straight ahead to set up the controller.
Clicking the realign button on it will re-calibrate the
controller and close the dialog.
A similar dialog is displayed on the VR environment.
The pointer and the window are re-centered at the same time.
@felipeerias felipeerias force-pushed the felipeerias/vg-realign-start branch from 0470785 to e3b67cf Compare May 16, 2024 09:20
@felipeerias felipeerias merged commit 0c915d7 into main May 16, 2024
20 checks passed
@felipeerias felipeerias deleted the felipeerias/vg-realign-start branch May 16, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants