[Vision Glass] Beam extends all the way to the pointer #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svillar
reviewed
May 1, 2024
There was a problem hiding this comment.
So I have some doubts about this patch mainly for two reasons:
- then the beam is not visible it does not really matter that we extend it to the pointer because it isn't visible either. I'd suggest adding some kind of visual indicator instead.
- making the beam "touch" the pointer gives a weird feeling because the pointer position is stabilized but the beam does not, so the feeling is weird
felipeerias
force-pushed
the
felipeerias/vg-long-beam
branch
from
d3c4201
to
ee44a07
Compare
|
@svillar I've added a small gap between the beam and the pointer so it looks a bit better. Another small concern is that our beam is actually a very narrow pyramid so when we make it taller the tip becomes fuzzy (too thin for the pixels on the screen). |
It is easy to get lost while using the Vision Glass because the controllers are not drawn in the 3D world and the narrow field of view means that the beam is not always visible to the user. This change extends the beam so it reaches all the way to the pointer, making the UI more understandable.
felipeerias
force-pushed
the
felipeerias/vg-long-beam
branch
from
ee44a07
to
d79f985
Compare
|
This change requires the method |
svillar
reviewed
May 23, 2024
svillar
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is easy to get lost while using the Vision Glass because the controllers are not drawn in the 3D world and the narrow field of view means that the beam is not always visible to the user.
This change extends the beam so it reaches all the way to the pointer, making the UI easier and more understandable.