[Vision Glass] Fix theming issues #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main application (and therefore the UI for VR) uses FxR_Dark, which fixes all the glitches with text colors, theming, etc. The theme for the phone UI is applied with a LayoutInflater which uses a different theme, which ensures that the correct values are applied in a way that does not interfere with the VR interface. Colors of the status and navigation bars are specified in FxR.Dark to ensure that they are properly applied. This doesn't affect VR.
svillar
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main application (and therefore the UI for VR) uses FxR_Dark, which fixes all the glitches with text colors, theming, etc.
The theme for the phone UI is applied with a LayoutInflater which uses a different theme, which ensures that the correct values are applied in a way that does not interfere with the VR interface.
Colors of the status and navigation bars are specified in FxR.Dark to ensure that they are properly applied. This doesn't affect VR.