Do not instantiate the Runtime in crash reporter service

[svillar]

Currently the CrashReporter service uses the runtime to create a CrashReportIntent. The reason why it does that is because the CrashReportIntent receives some parameters that depend on the backend (Gecko,Chromium) which cannot be resolved at build time.

By the time the CrashReporter creates that intent the runtime might not exist (like after a crash in the application). This means that the service will try to create it. The problem is that creating the runtime might not be possible, for example the GeckoRuntime must be created in the main thread but the crash reporter service is run in an async task as it can be see in this backtrace:

2022-09-08 14:15:38.005 20233-20267/com.igalia.wolvic.dev E/AndroidRuntime: FATAL EXCEPTION: AsyncTask #1
Process: com.igalia.wolvic.dev:crash, PID: 20233
java.lang.RuntimeException: An error occurred while executing doInBackground()
at android.os.AsyncTask$4.done(AsyncTask.java:399)
at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:383)
at java.util.concurrent.FutureTask.setException(FutureTask.java:252)
at java.util.concurrent.FutureTask.run(FutureTask.java:271)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.lang.Thread.run(Thread.java:919)
Caused by: java.lang.IllegalThreadStateException: Expected thread 2 ("main"), but running on thread 930 ("AsyncTask #1")
at org.mozilla.gecko.util.ThreadUtils.assertOnThreadComparison(ThreadUtils.java:127)
at org.mozilla.gecko.util.ThreadUtils.assertOnThread(ThreadUtils.java:93)
at org.mozilla.gecko.util.ThreadUtils.assertOnUiThread(ThreadUtils.java:84)
at org.mozilla.geckoview.GeckoRuntime.create(GeckoRuntime.java:552)
at com.igalia.wolvic.browser.api.impl.RuntimeImpl.(RuntimeImpl.java:72)
at com.igalia.wolvic.browser.api.WFactory.createRuntime(WFactory.java:14)
at com.igalia.wolvic.browser.engine.EngineProvider.getOrCreateRuntime(EngineProvider.kt:67)
at com.igalia.wolvic.crashreporting.CrashReporterService.onHandleWork(CrashReporterService.java:65)
at androidx.core.app.JobIntentService$CommandProcessor.doInBackground(JobIntentService.java:392)
at androidx.core.app.JobIntentService$CommandProcessor.doInBackground(JobIntentService.java:383)
at android.os.AsyncTask$3.call(AsyncTask.java:378)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) 
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) 
at java.lang.Thread.run(Thread.java:919) 

This is why we have to add an extra class per backend that is able to create those intents without having to instantiate the runtime.

[svillar]

Let's retake this later

[HollowMan6]

Should resolve #1029

Now it looks like it's fixed, as I can see in the log that Crash reporter job finished. Although I'm not sure about how to avoid the ForegroundServiceDidNotStartInTimeException here:

2023-10-01 23:05:57.684  1887-2183  VRB[CrashR...erService] com.igalia.wolvic                    D  Content process crash Intent { act=org.mozilla.gecko.ACTION_CRASHED cmp=com.igalia.wolvic/.browser.api.impl.CrashReporterServiceImpl (has extras) }
2023-10-01 23:05:57.686  1887-2183  VRB[CrashR...erService] com.igalia.wolvic                    D  Crash reporter job finished
2023-10-01 23:06:05.433  1887-1887  AndroidRuntime          com.igalia.wolvic                    D  Shutting down VM
2023-10-01 23:06:05.437  1887-1887  AndroidRuntime          com.igalia.wolvic                    E  FATAL EXCEPTION: main
                                                                                                    Process: com.igalia.wolvic:crash, PID: 1887
                                                                                                    android.app.RemoteServiceException$ForegroundServiceDidNotStartInTimeException: Context.startForegroundService() did not then call Service.startForeground(): ServiceRecord{a582c46 u0 com.igalia.wolvic/.browser.api.impl.CrashReporterServiceImpl}
                                                                                                    	at android.app.ActivityThread.generateForegroundServiceDidNotStartInTimeException(ActivityThread.java:1986)
                                                                                                    	at android.app.ActivityThread.throwRemoteServiceException(ActivityThread.java:1957)
                                                                                                    	at android.app.ActivityThread.access$2700(ActivityThread.java:259)
                                                                                                    	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2211)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:214)
                                                                                                    	at android.os.Looper.loop(Looper.java:304)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:7909)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1010)
2023-10-01 23:06:05.442  1887-1887  Process                 com.igalia.wolvic                    I  Sending signal. PID: 1887 SIG: 9

[HollowMan6]

Managed to replace deprecated JobIntentService with Service by referring to
https://github.com/fabricedesre/gecko-dev/blob/master/mobile/android/geckoview_example/src/main/java/org/mozilla/geckoview_example/ExampleCrashHandler.java

[HollowMan6]

cc: @svillar in case you haven't aware that this is reopened.

[HollowMan6]

Self-approve

[svillar]

Abandoning. We've already landed a couple of patches mitigating this issue.