Expose combo filtering strategy 14.0.x #11844
Merged
+200
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # projects/igniteui-angular/src/lib/combo/combo.common.ts # projects/igniteui-angular/src/lib/combo/combo.component.html
# Conflicts: # projects/igniteui-angular/src/lib/combo/combo.common.ts
# Conflicts: # CHANGELOG.md
wnvko
added
combo
filtering
simple-combo
version: 14.0.x
💥 status: in-test
Lipata
previously approved these changes
Jul 11, 2022
kdinev
requested changes
Jul 12, 2022
| @@ -875,13 +894,29 @@ export abstract class IgxComboBaseDirective extends DisplayDensityBase implement | |||
| protected destroy$ = new Subject<any>(); | |||
| protected _onTouchedCallback: () => void = noop; | |||
| protected _onChangeCallback: (_: any) => void = noop; | |||
| protected _defaultFilterFunction = (collection: any[], searchValue: any, matchCase: boolean): any[] => { | |||
There was a problem hiding this comment.
Define the default filtering function in the pipe and pass it as a default value for the transform method filterFunction parameter. This way when your combo input filterFunction is undefined, the default logic will be applied.
wnvko
changed the title
Lipata
previously approved these changes
Jul 12, 2022
Lipata
added
✅ status: verified
kdinev
requested changes
Jul 12, 2022
| * ``` | ||
| */ | ||
| @Input() | ||
| public get filterFunction(): (collection: any[], searchValue: any, caseSensitive: boolean) => any[] { |
There was a problem hiding this comment.
You no longer need a get and a set as well as a private variable!
|
|
||
| public transform( | ||
| collection: any[], | ||
| filterFunction: (collection: any[], searchValue: any, caseSensitive: boolean) => any[], |
There was a problem hiding this comment.
Move this to the end and assign it in the function definition to _defaultFilterFunction
Lipata
approved these changes
Jul 12, 2022
kdinev
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9884
Closes #11532
Closes #11810
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)