-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(combo): selectable unique falsy values #11610 #11859
Merged
Merged
+226
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should we make this work and with array of primitive values, e.g. |
@wnvko I would say not really. Those values don't have meaningful display representation to the end-user, so I don't consider this to be a real scenario that we should support. |
wnvko
previously approved these changes
Jul 15, 2022
projects/igniteui-angular/src/lib/simple-combo/simple-combo.component.ts
Show resolved
Hide resolved
wnvko
requested changes
Jul 19, 2022
projects/igniteui-angular/src/lib/simple-combo/simple-combo.component.ts
Show resolved
Hide resolved
wnvko
approved these changes
Jul 19, 2022
jackofdiamond5
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
combo
simple-combo
version: 14.0.x
✅ status: verified
Applies to PRs that have passed manual verification
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11610
Related #10952
** NOTE FOR TESTING **: Please verify that the scenario in this conversation is also covered by the fix!
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)