Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree): Make the tree scroll automatically when it reaches its parent height. #11912

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

desig9stein
Copy link
Contributor

@desig9stein desig9stein commented Jul 28, 2022

Closes #11848

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Sorry, something went wrong.

@zdrawku zdrawku added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Jul 28, 2022
@zdrawku zdrawku merged commit 8921a35 into 14.0.x Jul 28, 2022
@zdrawku zdrawku deleted the mpopov/teee_auto_scroll_14.0.x branch July 28, 2022 07:35
@@ -127,6 +127,8 @@
%tree-display {
display: block;
z-index: 0;
height: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@desig9stein we've reconsidered the whole approach. Could you please make an additional change and remove the whole height definition. Let the change be only adding overflow-y: auto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tree version: 14.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants