chore(*): Add aria-describedby reference to error message element as … #12051
Conversation
…well since readers are more likely to read it than aria-errormessage.
| @@ -472,6 +472,9 @@ export class IgxGridCellComponent implements OnInit, OnChanges, OnDestroy, CellT | |||
| /** @hidden @internal */ | |||
| @HostBinding('attr.aria-describedby') | |||
| public get describeBy() { | |||
There was a problem hiding this comment.
PS: There's also a describedby in the row templates
…r. Also remove aria-errormessage since it's not supported.
mddragnev
added
✅ status: verified
|
This does work with MacOS VoiceOver and NVDA. |
|
@damyanpetev I think it reads better when there's no aria-describedby on the cell that point to the header (does not repeat the header twice in NVDA) but it might be a breaking change since there are some tests that explicitly expect the old describedby attribute. Should we remove it or just set both the error and the header ref for describedby? |
Actually it also seem to depend on the browser and reader.
So I guess it's better to go with both so that there's no breaking change and the header is read at least once on every browser/reader. |
MayaKirova
added
❌ status: awaiting-test
mddragnev
added
💥 status: in-test
mddragnev
added
✅ status: verified
…well since readers are more likely to read it than aria-errormessage.
Note: Works with more advanced readers like NVDA. More basic ones like the built-in win Narrator don't seem to read it though.
Closes #12043
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)