Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(grid): position invalid icon on right #12079

Merged
merged 3 commits into from
Sep 16, 2022

Conversation

didimmova
Copy link
Contributor

Closes #12058

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Sorry, something went wrong.

@didimmova didimmova requested a review from simeonoff September 14, 2022 13:03
@MayaKirova MayaKirova added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Sep 14, 2022
…_grid-theme.scss

Co-authored-by: Simeon Simeonoff <sim.simeonoff@gmail.com>
@didimmova didimmova requested a review from simeonoff September 15, 2022 07:39
simeonoff
simeonoff previously approved these changes Sep 16, 2022
@simeonoff simeonoff changed the base branch from master to 14.1.x September 16, 2022 06:51
@simeonoff simeonoff dismissed their stale review September 16, 2022 06:51

The base branch was changed.

@simeonoff simeonoff self-requested a review September 16, 2022 07:11
@simeonoff simeonoff merged commit bf95d09 into 14.1.x Sep 16, 2022
@simeonoff simeonoff deleted the didimmova/grid-invalid-icon branch September 16, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid styling version: 14.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using a custom template the validation error icon is not aligned to the right.
3 participants