Select falsy values via ngModel - 14.1.x #12096

RivaIvanova · 2022-09-19T06:28:31Z

Closes #12048

NOTE FOR TESTING :

Should be able to select all falsy values except 'undefined', i.e., false, '', 0, NaN, null.
For complex data, if there is an item with valueKey=undefined it should be displayed in the dropdown, but cannot be selected.
When testing NaN use an additional variable in the ts file

public selectNaN: any = NaN;

<igx-simple-combo [data]="data" [(ngModel)]="selectedValue"></igx-simple-combo>
<button igxButton (click)="selectedValue = selectNaN"> NaN </button>

Assigning it directly in the html file shows an error "Property 'NaN' does not exist on type 'ComboSampleComponent'.ngtsc(2339)" and the variable bound to the ngModel is assumed as 'undefined'.

Test IgxSimpleCombo when bound to the ngModel with required attribute set:
- if required attribute is set, null, undefined, '' should not be selected in IgxSimpleCombo, otherwise, null, '' should be selected.

Additional information (check all that apply):

Checklist:

All relevant tags have been applied to this PR
This PR includes unit tests covering all the new code (test guidelines)
This PR includes API docs for newly added methods/properties (api docs guidelines)
This PR includes feature/README.MD updates for the feature docs
This PR includes general feature table updates in the root README.MD
This PR includes CHANGELOG.MD updates for newly added functionality
This PR contains breaking changes
This PR includes ng update migrations for the breaking changes (migrations guidelines)
This PR includes behavioral changes and the feature specification has been updated with them

…into rivanova/fix-12048-14.1.x

…efined

…into rivanova/fix-12048-14.1.x

… form

…active form

* chore(*): updating angular/core and cli deps * chore(*): updating other deps * chore(*): updating typescript * chore(*): fixing package version * chore(deps): removing ^ from typedoc version * chore(*): fixing indentation in dd tests * chore(*): updating dependencies * chore(*): updating tests.ts * chore(*): updating dependencies * fix(excel-exporter): export correct number of rows#12086 (#12121) * fix(excel-exporter): export correct number of rows#12086 * fix(excel-exporter): fix total rowCount with multi col headers#12086 * fix(excel-exporter): fix spacing#12086 * fix(i18n): Updating Grid localization for all languages - 14.1.x * fix(igxGrid): Fix end edit with Enter when trigger is blur by moving it to more common place. (#12101) Co-authored-by: MKirova <MKirova@DEV-MKIROVA> Co-authored-by: Deyan Kamburov <dkamburov@users.noreply.github.com> * fix(radio): focus nativeElement (#12151) * chore(*): updating dependencies * Select falsy values via ngModel - 14.1.x (#12096) * test(simple-combo): should select falsy values with "writeValue" method * fix(simple-combo): select falsy values with "writeValue" method * refactor(simple-combo): use 'const' for hasSelection variable * test(selectionService): should add items with falsy itemID except undefined * fix(selectionService): add items with falsy itemID except undefined * test(combos): should select falsy values except "undefined" * fix(combos): select falsy values except "undefined" * fix(combos): display and select "null" in dropdown * test(selectionService): removing an outdated test * fix(selectionService): removing throw error check * fix(combos): additional checks for nullish values * chore(combos): add comment for template check * chore(remoteNWindService): remove debugger * test(combos): should remove undefined from array of primitive data * fix(combos): remove undefined from array of primitive data * fix(combos): remove undefined in data setter * fix(simple-combo): show all items in dropdown * chore(combo-pipes): add comment for grouping pipe * test(simple-combo): should not select null, undefined, '' in template form * fix(simple-combo): not select null, undefined, '' in template form * fix(simple-combo): not select null, undefined, '' in reactive form * fix(simple-combo): not select null, undefined, '' from dropdown in reactive form Co-authored-by: Teodosia Hristodorova <52423497+teodosiah@users.noreply.github.com> * chore(cypress): migrating to cypress 10 * chore(*): fixing tests configure-suite * chore(*): fixing the typedoc tsconfig * chore(*): updating dependencies * chore(*): updating @angular/core @angular/cli * chore(*): reverting jasmine and jasmine-core ver * test(d&d): fixing async tests * chore(d&d): removing fdescribe * chore(*): fixing grid and d&d tests * chore(*): fingers crossed this fixes EVERYTHING * chore(*): waitForAsync not imported * test(hgrid): fixing global failure for tests * test(migrations): fixing tsUtils typing * test(migrations): fixing bufferencoding typing * chore(*): two hands fingers crossed... Co-authored-by: Georgi Anastasov <48180072+georgianastasov@users.noreply.github.com> Co-authored-by: Rumyana Andriova <54146583+randriova@users.noreply.github.com> Co-authored-by: Maya <MKirova@infragistics.com> Co-authored-by: MKirova <MKirova@DEV-MKIROVA> Co-authored-by: Deyan Kamburov <dkamburov@users.noreply.github.com> Co-authored-by: Zdravko Kolev <zkolev@infragistics.com> Co-authored-by: Silvia Ivanova <59446295+SisIvanova@users.noreply.github.com> Co-authored-by: Riva Ivanova <49126110+RivaIvanova@users.noreply.github.com> Co-authored-by: Teodosia Hristodorova <52423497+teodosiah@users.noreply.github.com>

* chore(*): updating angular/core and cli deps * chore(*): updating other deps * chore(*): updating typescript * chore(*): fixing package version * chore(deps): removing ^ from typedoc version * chore(*): fixing indentation in dd tests * chore(*): updating dependencies * chore(*): updating tests.ts * chore(*): updating dependencies * fix(excel-exporter): export correct number of rows#12086 (#12121) * fix(excel-exporter): export correct number of rows#12086 * fix(excel-exporter): fix total rowCount with multi col headers#12086 * fix(excel-exporter): fix spacing#12086 * fix(i18n): Updating Grid localization for all languages - 14.1.x * fix(igxGrid): Fix end edit with Enter when trigger is blur by moving it to more common place. (#12101) Co-authored-by: MKirova <MKirova@DEV-MKIROVA> Co-authored-by: Deyan Kamburov <dkamburov@users.noreply.github.com> * fix(radio): focus nativeElement (#12151) * chore(*): updating dependencies * Select falsy values via ngModel - 14.1.x (#12096) * test(simple-combo): should select falsy values with "writeValue" method * fix(simple-combo): select falsy values with "writeValue" method * refactor(simple-combo): use 'const' for hasSelection variable * test(selectionService): should add items with falsy itemID except undefined * fix(selectionService): add items with falsy itemID except undefined * test(combos): should select falsy values except "undefined" * fix(combos): select falsy values except "undefined" * fix(combos): display and select "null" in dropdown * test(selectionService): removing an outdated test * fix(selectionService): removing throw error check * fix(combos): additional checks for nullish values * chore(combos): add comment for template check * chore(remoteNWindService): remove debugger * test(combos): should remove undefined from array of primitive data * fix(combos): remove undefined from array of primitive data * fix(combos): remove undefined in data setter * fix(simple-combo): show all items in dropdown * chore(combo-pipes): add comment for grouping pipe * test(simple-combo): should not select null, undefined, '' in template form * fix(simple-combo): not select null, undefined, '' in template form * fix(simple-combo): not select null, undefined, '' in reactive form * fix(simple-combo): not select null, undefined, '' from dropdown in reactive form Co-authored-by: Teodosia Hristodorova <52423497+teodosiah@users.noreply.github.com> * chore(cypress): migrating to cypress 10 * chore(*): fixing tests configure-suite * chore(*): fixing the typedoc tsconfig * chore(*): updating dependencies * chore(*): updating @angular/core @angular/cli * chore(*): reverting jasmine and jasmine-core ver * test(d&d): fixing async tests * chore(d&d): removing fdescribe * chore(*): fixing grid and d&d tests * chore(*): fingers crossed this fixes EVERYTHING * chore(*): waitForAsync not imported * test(hgrid): fixing global failure for tests * test(migrations): fixing tsUtils typing * test(migrations): fixing bufferencoding typing * chore(*): two hands fingers crossed... * chore(*): getting rid of jasmine-spec-tags * chore(*): adding node 18.x to execution matrix * ci(azure-pipelines): changing karma conf * test(hgrid): optimizing hgrid selection tests * chore(*): removing fdescribe * chore(*): increasing jasmine timeout again * chore(*): updating types versions * test(perf): disabling performance tests * chore(*): trying something out * chore(*): returning parallel * test(hgrid): speeding up hgrid tests * test(hgrid): adding DEBOUNCE_TIME to two tests * test(hgrid): adding a common describe * test(hgrid): fixing a failing test * chore(*): ofc forgot the fdescribe * chore(*): fixing indentation * chore(*): increasing a timeout Co-authored-by: Georgi Anastasov <48180072+georgianastasov@users.noreply.github.com> Co-authored-by: Rumyana Andriova <54146583+randriova@users.noreply.github.com> Co-authored-by: Maya <MKirova@infragistics.com> Co-authored-by: MKirova <MKirova@DEV-MKIROVA> Co-authored-by: Deyan Kamburov <dkamburov@users.noreply.github.com> Co-authored-by: Zdravko Kolev <zkolev@infragistics.com> Co-authored-by: Silvia Ivanova <59446295+SisIvanova@users.noreply.github.com> Co-authored-by: Riva Ivanova <49126110+RivaIvanova@users.noreply.github.com> Co-authored-by: Teodosia Hristodorova <52423497+teodosiah@users.noreply.github.com>

* chore(*): updating angular/core and cli deps * chore(*): updating other deps * chore(*): updating typescript * chore(*): fixing package version * chore(deps): removing ^ from typedoc version * chore(*): fixing indentation in dd tests * chore(*): updating dependencies * chore(*): updating tests.ts * chore(*): updating dependencies * fix(excel-exporter): export correct number of rows#12086 (#12121) * fix(excel-exporter): export correct number of rows#12086 * fix(excel-exporter): fix total rowCount with multi col headers#12086 * fix(excel-exporter): fix spacing#12086 * fix(i18n): Updating Grid localization for all languages - 14.1.x * fix(igxGrid): Fix end edit with Enter when trigger is blur by moving it to more common place. (#12101) Co-authored-by: MKirova <MKirova@DEV-MKIROVA> Co-authored-by: Deyan Kamburov <dkamburov@users.noreply.github.com> * fix(radio): focus nativeElement (#12151) * chore(*): updating dependencies * Select falsy values via ngModel - 14.1.x (#12096) * test(simple-combo): should select falsy values with "writeValue" method * fix(simple-combo): select falsy values with "writeValue" method * refactor(simple-combo): use 'const' for hasSelection variable * test(selectionService): should add items with falsy itemID except undefined * fix(selectionService): add items with falsy itemID except undefined * test(combos): should select falsy values except "undefined" * fix(combos): select falsy values except "undefined" * fix(combos): display and select "null" in dropdown * test(selectionService): removing an outdated test * fix(selectionService): removing throw error check * fix(combos): additional checks for nullish values * chore(combos): add comment for template check * chore(remoteNWindService): remove debugger * test(combos): should remove undefined from array of primitive data * fix(combos): remove undefined from array of primitive data * fix(combos): remove undefined in data setter * fix(simple-combo): show all items in dropdown * chore(combo-pipes): add comment for grouping pipe * test(simple-combo): should not select null, undefined, '' in template form * fix(simple-combo): not select null, undefined, '' in template form * fix(simple-combo): not select null, undefined, '' in reactive form * fix(simple-combo): not select null, undefined, '' from dropdown in reactive form Co-authored-by: Teodosia Hristodorova <52423497+teodosiah@users.noreply.github.com> * chore(cypress): migrating to cypress 10 * chore(*): fixing tests configure-suite * chore(*): fixing the typedoc tsconfig * chore(*): updating dependencies * chore(*): updating @angular/core @angular/cli * chore(*): reverting jasmine and jasmine-core ver * test(d&d): fixing async tests * chore(d&d): removing fdescribe * chore(*): fixing grid and d&d tests * chore(*): fingers crossed this fixes EVERYTHING * chore(*): waitForAsync not imported * test(hgrid): fixing global failure for tests * test(migrations): fixing tsUtils typing * test(migrations): fixing bufferencoding typing * chore(*): two hands fingers crossed... * chore(*): getting rid of jasmine-spec-tags * chore(*): adding node 18.x to execution matrix * ci(azure-pipelines): changing karma conf * test(hgrid): optimizing hgrid selection tests * chore(*): removing fdescribe * chore(*): increasing jasmine timeout again * chore(*): updating types versions * test(perf): disabling performance tests * chore(*): updating to angular 15 rc0 * chore(*): adding a temporary --force on ci * chore(ci): changing to npm install for force * chore(*): updating the browserlist * test(checkbox, switch, radio): reworking disabled * chore(*): updating @angular/cli to 15 rc2 * chore(*): updating @angular/core to 15 RC2 * chore(*): updating dependencies * chore(*): reverting theming package version * chore(*): updating @angular/cli to 15 RC3 * chore(*): updating @angular/core to 15 RC3 * chore(schematics): update package.json & @igniteui/angular-schematics * chore(*): updating lock file * chore(*): updating @angular/core and cli to 15 rc4 * chore(*): updating more deps * chore(*): Revert "test(checkbox, switch, radio): reworking disabled" b3c88e2 * test(checkbox, switch, radio): bring back the test fixes from the revert * chore(migrations): add root which is required in the new angular.json schema * chore(*): ng update @angular/core@15.0.0 * chore(*): ng update @angular/cli@15.0.0 * chore(*): update product package.json * chore(*): updating @angular-eslint Co-authored-by: Georgi Anastasov <48180072+georgianastasov@users.noreply.github.com> Co-authored-by: Rumyana Andriova <54146583+randriova@users.noreply.github.com> Co-authored-by: Maya <MKirova@infragistics.com> Co-authored-by: MKirova <MKirova@DEV-MKIROVA> Co-authored-by: Deyan Kamburov <dkamburov@users.noreply.github.com> Co-authored-by: Zdravko Kolev <zkolev@infragistics.com> Co-authored-by: Silvia Ivanova <59446295+SisIvanova@users.noreply.github.com> Co-authored-by: Riva Ivanova <49126110+RivaIvanova@users.noreply.github.com> Co-authored-by: Teodosia Hristodorova <52423497+teodosiah@users.noreply.github.com> Co-authored-by: lipata <nikolay.alipiev@gmail.com> Co-authored-by: Deyan Kamburov <dkamburov@infragistics.com>

RivaIvanova added 2 commits September 19, 2022 09:23

test(simple-combo): should select falsy values with "writeValue" method

7002a4b

fix(simple-combo): select falsy values with "writeValue" method

29bd09b

RivaIvanova added ❌ status: awaiting-test simple-combo version: 14.1.x labels Sep 19, 2022

refactor(simple-combo): use 'const' for hasSelection variable

1bc1cf1

RivaIvanova requested a review from jackofdiamond5 September 19, 2022 09:29

Merge branch '14.1.x' into rivanova/fix-12048-14.1.x

1f2de4f

teodosiah assigned MonikaKirkova Sep 19, 2022

MonikaKirkova added 💥 status: in-test ✅ status: verified and removed ❌ status: awaiting-test 💥 status: in-test labels Sep 19, 2022

RivaIvanova added 🛠️ status: in-development and removed ✅ status: verified labels Sep 20, 2022

RivaIvanova added 5 commits September 21, 2022 09:53

Merge branch '14.1.x' of https://github.com/IgniteUI/igniteui-angular …

9ba2b27

…into rivanova/fix-12048-14.1.x

test(selectionService): should add items with falsy itemID except und…

4e4e37a

…efined

fix(selectionService): add items with falsy itemID except undefined

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

19fb724

test(combos): should select falsy values except "undefined"

55d4742

fix(combos): select falsy values except "undefined"

a86ef09

RivaIvanova added ❌ status: awaiting-test and removed 🛠️ status: in-development labels Sep 21, 2022

fix(combos): display and select "null" in dropdown

57c935c

RivaIvanova changed the title ~~[IgxSimpleCombo] Select falsy values - 14.1.x~~ Select falsy values via ngModel - 14.1.x Sep 26, 2022

RivaIvanova added 3 commits September 26, 2022 10:01

test(selectionService): removing an outdated test

88020cc

fix(selectionService): removing throw error check

d29af33

fix(combos): additional checks for nullish values

327e62d

RivaIvanova assigned teodosiah and unassigned MonikaKirkova Sep 26, 2022

chore(combos): add comment for template check

2221b30

chore(remoteNWindService): remove debugger

718239c

jackofdiamond5 previously approved these changes Sep 26, 2022

View reviewed changes

jackofdiamond5 added the squash-merge label Sep 26, 2022

teodosiah and others added 3 commits September 27, 2022 12:52

Merge branch '14.1.x' into rivanova/fix-12048-14.1.x

fc0d7e9

test(combos): should remove undefined from array of primitive data

68e6d27

fix(combos): remove undefined from array of primitive data

e2614aa

RivaIvanova added 🛠️ status: in-development and removed ❌ status: awaiting-test labels Sep 29, 2022

RivaIvanova dismissed jackofdiamond5’s stale review via e2614aa September 29, 2022 10:35

RivaIvanova added ❌ status: awaiting-test and removed 🛠️ status: in-development labels Sep 29, 2022

fix(combos): remove undefined in data setter

5eadd93

RivaIvanova requested a review from jackofdiamond5 September 29, 2022 14:52

RivaIvanova added 7 commits October 3, 2022 13:46

Merge branch '14.1.x' of https://github.com/IgniteUI/igniteui-angular …

19e814a

…into rivanova/fix-12048-14.1.x

fix(simple-combo): show all items in dropdown

bd77037

chore(combo-pipes): add comment for grouping pipe

ebcdde3

test(simple-combo): should not select null, undefined, '' in template…

eb591f1

… form

fix(simple-combo): not select null, undefined, '' in template form

1b64bc3

fix(simple-combo): not select null, undefined, '' in reactive form

da34493

fix(simple-combo): not select null, undefined, '' from dropdown in re…

71fc7c5

…active form

teodosiah added 💥 status: in-test ✅ status: verified and removed ❌ status: awaiting-test 💥 status: in-test labels Oct 5, 2022

jackofdiamond5 approved these changes Oct 6, 2022

View reviewed changes

ChronosSF merged commit 08d4719 into 14.1.x Oct 6, 2022

ChronosSF deleted the rivanova/fix-12048-14.1.x branch October 6, 2022 06:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Select falsy values via ngModel - 14.1.x #12096

Select falsy values via ngModel - 14.1.x #12096

RivaIvanova commented Sep 19, 2022 •

edited

Loading

Select falsy values via ngModel - 14.1.x #12096

Select falsy values via ngModel - 14.1.x #12096

Conversation

RivaIvanova commented Sep 19, 2022 • edited Loading

Additional information (check all that apply):

Checklist:

RivaIvanova commented Sep 19, 2022 •

edited

Loading