fix(excel-exporter): export correct number of rows#12086 #12121
Merged
+48
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgianastasov
added
❌ status: awaiting-test
projects/igniteui-angular/src/lib/services/excel/excel-files.ts
Outdated
Show resolved
Hide resolved
onlyexeption
added
💥 status: in-test
onlyexeption
added
✅ status: verified
onlyexeption
approved these changes
Sep 27, 2022
ChronosSF
pushed a commit
that referenced
this pull request
Oct 19, 2022
* chore(*): updating angular/core and cli deps * chore(*): updating other deps * chore(*): updating typescript * chore(*): fixing package version * chore(deps): removing ^ from typedoc version * chore(*): fixing indentation in dd tests * chore(*): updating dependencies * chore(*): updating tests.ts * chore(*): updating dependencies * fix(excel-exporter): export correct number of rows#12086 (#12121) * fix(excel-exporter): export correct number of rows#12086 * fix(excel-exporter): fix total rowCount with multi col headers#12086 * fix(excel-exporter): fix spacing#12086 * fix(i18n): Updating Grid localization for all languages - 14.1.x * fix(igxGrid): Fix end edit with Enter when trigger is blur by moving it to more common place. (#12101) Co-authored-by: MKirova <MKirova@DEV-MKIROVA> Co-authored-by: Deyan Kamburov <dkamburov@users.noreply.github.com> * fix(radio): focus nativeElement (#12151) * chore(*): updating dependencies * Select falsy values via ngModel - 14.1.x (#12096) * test(simple-combo): should select falsy values with "writeValue" method * fix(simple-combo): select falsy values with "writeValue" method * refactor(simple-combo): use 'const' for hasSelection variable * test(selectionService): should add items with falsy itemID except undefined * fix(selectionService): add items with falsy itemID except undefined * test(combos): should select falsy values except "undefined" * fix(combos): select falsy values except "undefined" * fix(combos): display and select "null" in dropdown * test(selectionService): removing an outdated test * fix(selectionService): removing throw error check * fix(combos): additional checks for nullish values * chore(combos): add comment for template check * chore(remoteNWindService): remove debugger * test(combos): should remove undefined from array of primitive data * fix(combos): remove undefined from array of primitive data * fix(combos): remove undefined in data setter * fix(simple-combo): show all items in dropdown * chore(combo-pipes): add comment for grouping pipe * test(simple-combo): should not select null, undefined, '' in template form * fix(simple-combo): not select null, undefined, '' in template form * fix(simple-combo): not select null, undefined, '' in reactive form * fix(simple-combo): not select null, undefined, '' from dropdown in reactive form Co-authored-by: Teodosia Hristodorova <52423497+teodosiah@users.noreply.github.com> * chore(cypress): migrating to cypress 10 * chore(*): fixing tests configure-suite * chore(*): fixing the typedoc tsconfig * chore(*): updating dependencies * chore(*): updating @angular/core @angular/cli * chore(*): reverting jasmine and jasmine-core ver * test(d&d): fixing async tests * chore(d&d): removing fdescribe * chore(*): fixing grid and d&d tests * chore(*): fingers crossed this fixes EVERYTHING * chore(*): waitForAsync not imported * test(hgrid): fixing global failure for tests * test(migrations): fixing tsUtils typing * test(migrations): fixing bufferencoding typing * chore(*): two hands fingers crossed... Co-authored-by: Georgi Anastasov <48180072+georgianastasov@users.noreply.github.com> Co-authored-by: Rumyana Andriova <54146583+randriova@users.noreply.github.com> Co-authored-by: Maya <MKirova@infragistics.com> Co-authored-by: MKirova <MKirova@DEV-MKIROVA> Co-authored-by: Deyan Kamburov <dkamburov@users.noreply.github.com> Co-authored-by: Zdravko Kolev <zkolev@infragistics.com> Co-authored-by: Silvia Ivanova <59446295+SisIvanova@users.noreply.github.com> Co-authored-by: Riva Ivanova <49126110+RivaIvanova@users.noreply.github.com> Co-authored-by: Teodosia Hristodorova <52423497+teodosiah@users.noreply.github.com>
ChronosSF
pushed a commit
that referenced
this pull request
Oct 28, 2022
* chore(*): updating angular/core and cli deps * chore(*): updating other deps * chore(*): updating typescript * chore(*): fixing package version * chore(deps): removing ^ from typedoc version * chore(*): fixing indentation in dd tests * chore(*): updating dependencies * chore(*): updating tests.ts * chore(*): updating dependencies * fix(excel-exporter): export correct number of rows#12086 (#12121) * fix(excel-exporter): export correct number of rows#12086 * fix(excel-exporter): fix total rowCount with multi col headers#12086 * fix(excel-exporter): fix spacing#12086 * fix(i18n): Updating Grid localization for all languages - 14.1.x * fix(igxGrid): Fix end edit with Enter when trigger is blur by moving it to more common place. (#12101) Co-authored-by: MKirova <MKirova@DEV-MKIROVA> Co-authored-by: Deyan Kamburov <dkamburov@users.noreply.github.com> * fix(radio): focus nativeElement (#12151) * chore(*): updating dependencies * Select falsy values via ngModel - 14.1.x (#12096) * test(simple-combo): should select falsy values with "writeValue" method * fix(simple-combo): select falsy values with "writeValue" method * refactor(simple-combo): use 'const' for hasSelection variable * test(selectionService): should add items with falsy itemID except undefined * fix(selectionService): add items with falsy itemID except undefined * test(combos): should select falsy values except "undefined" * fix(combos): select falsy values except "undefined" * fix(combos): display and select "null" in dropdown * test(selectionService): removing an outdated test * fix(selectionService): removing throw error check * fix(combos): additional checks for nullish values * chore(combos): add comment for template check * chore(remoteNWindService): remove debugger * test(combos): should remove undefined from array of primitive data * fix(combos): remove undefined from array of primitive data * fix(combos): remove undefined in data setter * fix(simple-combo): show all items in dropdown * chore(combo-pipes): add comment for grouping pipe * test(simple-combo): should not select null, undefined, '' in template form * fix(simple-combo): not select null, undefined, '' in template form * fix(simple-combo): not select null, undefined, '' in reactive form * fix(simple-combo): not select null, undefined, '' from dropdown in reactive form Co-authored-by: Teodosia Hristodorova <52423497+teodosiah@users.noreply.github.com> * chore(cypress): migrating to cypress 10 * chore(*): fixing tests configure-suite * chore(*): fixing the typedoc tsconfig * chore(*): updating dependencies * chore(*): updating @angular/core @angular/cli * chore(*): reverting jasmine and jasmine-core ver * test(d&d): fixing async tests * chore(d&d): removing fdescribe * chore(*): fixing grid and d&d tests * chore(*): fingers crossed this fixes EVERYTHING * chore(*): waitForAsync not imported * test(hgrid): fixing global failure for tests * test(migrations): fixing tsUtils typing * test(migrations): fixing bufferencoding typing * chore(*): two hands fingers crossed... * chore(*): getting rid of jasmine-spec-tags * chore(*): adding node 18.x to execution matrix * ci(azure-pipelines): changing karma conf * test(hgrid): optimizing hgrid selection tests * chore(*): removing fdescribe * chore(*): increasing jasmine timeout again * chore(*): updating types versions * test(perf): disabling performance tests * chore(*): trying something out * chore(*): returning parallel * test(hgrid): speeding up hgrid tests * test(hgrid): adding DEBOUNCE_TIME to two tests * test(hgrid): adding a common describe * test(hgrid): fixing a failing test * chore(*): ofc forgot the fdescribe * chore(*): fixing indentation * chore(*): increasing a timeout Co-authored-by: Georgi Anastasov <48180072+georgianastasov@users.noreply.github.com> Co-authored-by: Rumyana Andriova <54146583+randriova@users.noreply.github.com> Co-authored-by: Maya <MKirova@infragistics.com> Co-authored-by: MKirova <MKirova@DEV-MKIROVA> Co-authored-by: Deyan Kamburov <dkamburov@users.noreply.github.com> Co-authored-by: Zdravko Kolev <zkolev@infragistics.com> Co-authored-by: Silvia Ivanova <59446295+SisIvanova@users.noreply.github.com> Co-authored-by: Riva Ivanova <49126110+RivaIvanova@users.noreply.github.com> Co-authored-by: Teodosia Hristodorova <52423497+teodosiah@users.noreply.github.com>
ChronosSF
pushed a commit
that referenced
this pull request
Nov 17, 2022
* chore(*): updating angular/core and cli deps * chore(*): updating other deps * chore(*): updating typescript * chore(*): fixing package version * chore(deps): removing ^ from typedoc version * chore(*): fixing indentation in dd tests * chore(*): updating dependencies * chore(*): updating tests.ts * chore(*): updating dependencies * fix(excel-exporter): export correct number of rows#12086 (#12121) * fix(excel-exporter): export correct number of rows#12086 * fix(excel-exporter): fix total rowCount with multi col headers#12086 * fix(excel-exporter): fix spacing#12086 * fix(i18n): Updating Grid localization for all languages - 14.1.x * fix(igxGrid): Fix end edit with Enter when trigger is blur by moving it to more common place. (#12101) Co-authored-by: MKirova <MKirova@DEV-MKIROVA> Co-authored-by: Deyan Kamburov <dkamburov@users.noreply.github.com> * fix(radio): focus nativeElement (#12151) * chore(*): updating dependencies * Select falsy values via ngModel - 14.1.x (#12096) * test(simple-combo): should select falsy values with "writeValue" method * fix(simple-combo): select falsy values with "writeValue" method * refactor(simple-combo): use 'const' for hasSelection variable * test(selectionService): should add items with falsy itemID except undefined * fix(selectionService): add items with falsy itemID except undefined * test(combos): should select falsy values except "undefined" * fix(combos): select falsy values except "undefined" * fix(combos): display and select "null" in dropdown * test(selectionService): removing an outdated test * fix(selectionService): removing throw error check * fix(combos): additional checks for nullish values * chore(combos): add comment for template check * chore(remoteNWindService): remove debugger * test(combos): should remove undefined from array of primitive data * fix(combos): remove undefined from array of primitive data * fix(combos): remove undefined in data setter * fix(simple-combo): show all items in dropdown * chore(combo-pipes): add comment for grouping pipe * test(simple-combo): should not select null, undefined, '' in template form * fix(simple-combo): not select null, undefined, '' in template form * fix(simple-combo): not select null, undefined, '' in reactive form * fix(simple-combo): not select null, undefined, '' from dropdown in reactive form Co-authored-by: Teodosia Hristodorova <52423497+teodosiah@users.noreply.github.com> * chore(cypress): migrating to cypress 10 * chore(*): fixing tests configure-suite * chore(*): fixing the typedoc tsconfig * chore(*): updating dependencies * chore(*): updating @angular/core @angular/cli * chore(*): reverting jasmine and jasmine-core ver * test(d&d): fixing async tests * chore(d&d): removing fdescribe * chore(*): fixing grid and d&d tests * chore(*): fingers crossed this fixes EVERYTHING * chore(*): waitForAsync not imported * test(hgrid): fixing global failure for tests * test(migrations): fixing tsUtils typing * test(migrations): fixing bufferencoding typing * chore(*): two hands fingers crossed... * chore(*): getting rid of jasmine-spec-tags * chore(*): adding node 18.x to execution matrix * ci(azure-pipelines): changing karma conf * test(hgrid): optimizing hgrid selection tests * chore(*): removing fdescribe * chore(*): increasing jasmine timeout again * chore(*): updating types versions * test(perf): disabling performance tests * chore(*): updating to angular 15 rc0 * chore(*): adding a temporary --force on ci * chore(ci): changing to npm install for force * chore(*): updating the browserlist * test(checkbox, switch, radio): reworking disabled * chore(*): updating @angular/cli to 15 rc2 * chore(*): updating @angular/core to 15 RC2 * chore(*): updating dependencies * chore(*): reverting theming package version * chore(*): updating @angular/cli to 15 RC3 * chore(*): updating @angular/core to 15 RC3 * chore(schematics): update package.json & @igniteui/angular-schematics * chore(*): updating lock file * chore(*): updating @angular/core and cli to 15 rc4 * chore(*): updating more deps * chore(*): Revert "test(checkbox, switch, radio): reworking disabled" b3c88e2 * test(checkbox, switch, radio): bring back the test fixes from the revert * chore(migrations): add root which is required in the new angular.json schema * chore(*): ng update @angular/core@15.0.0 * chore(*): ng update @angular/cli@15.0.0 * chore(*): update product package.json * chore(*): updating @angular-eslint Co-authored-by: Georgi Anastasov <48180072+georgianastasov@users.noreply.github.com> Co-authored-by: Rumyana Andriova <54146583+randriova@users.noreply.github.com> Co-authored-by: Maya <MKirova@infragistics.com> Co-authored-by: MKirova <MKirova@DEV-MKIROVA> Co-authored-by: Deyan Kamburov <dkamburov@users.noreply.github.com> Co-authored-by: Zdravko Kolev <zkolev@infragistics.com> Co-authored-by: Silvia Ivanova <59446295+SisIvanova@users.noreply.github.com> Co-authored-by: Riva Ivanova <49126110+RivaIvanova@users.noreply.github.com> Co-authored-by: Teodosia Hristodorova <52423497+teodosiah@users.noreply.github.com> Co-authored-by: lipata <nikolay.alipiev@gmail.com> Co-authored-by: Deyan Kamburov <dkamburov@infragistics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12086
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)