Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IgxSimpleCombo]: clear input on blur when combo is collapsed - 14.2.x #12168

Merged
merged 4 commits into from
Oct 17, 2022

Conversation

RivaIvanova
Copy link
Member

Closes #12100

This PR also fixes an issue where the closing event was emitted once when closing the combo via the toggle button, but twice when closing it when clicking outside of it.

closing

NOTE FOR TESTING :

  • Verify that the input is cleared when closing the combo via the toggle button and immediately clicking outside of the combo, i.e., the below should not be reproducible:

collapsed-demo

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
coditva Utkarsh Maheshwari
…psed
@RivaIvanova RivaIvanova added simple-combo version: 14.2.x 🛠️ status: in-development Issues and PRs with active development on them ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Oct 7, 2022
RivaIvanova and others added 2 commits October 11, 2022 13:26

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@teodosiah teodosiah added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Oct 17, 2022
@ChronosSF ChronosSF merged commit bd482d9 into 14.2.x Oct 17, 2022
@ChronosSF ChronosSF deleted the rivanova/fix-12100-14.2.x branch October 17, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simple-combo version: 14.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants