Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(circular-progress): brakes on zoom in Safari #12179

Merged
merged 3 commits into from
Oct 21, 2022
Merged

fix(circular-progress): brakes on zoom in Safari #12179

merged 3 commits into from
Oct 21, 2022
+42 −33

Conversation

desig9stein
Copy link
Contributor

@desig9stein desig9stein commented Oct 11, 2022 •
edited
Loading

Closes #12173

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Sorry, something went wrong.

@desig9stein desig9stein requested a review from simeonoff October 11, 2022 12:50
@simeonoff simeonoff changed the title Fix broken circular progress on zoom in/out fix(circular-progress): brakes on zoom in/out Oct 19, 2022
@simeonoff simeonoff changed the title fix(circular-progress): brakes on zoom in/out fix(circular-progress): brakes on zoom in/out in Safari Oct 19, 2022
@simeonoff simeonoff changed the title fix(circular-progress): brakes on zoom in/out in Safari fix(circular-progress): brakes on zoom in Safari Oct 19, 2022
@simeonoff simeonoff linked an issue Oct 19, 2022 that may be closed by this pull request
The circular progress bar looks broken when the page is zoomed in safari. #12173
Closed
@simeonoff simeonoff added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Oct 20, 2022
@simeonoff simeonoff merged commit a09e51d into 14.2.x Oct 21, 2022
@simeonoff simeonoff deleted the mpopov/progress-safari-14.2 branch October 21, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff

Assignees
No one assigned
Labels
circular-progress 🌐 browser: Safari version: 14.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The circular progress bar looks broken when the page is zoomed in safari.
2 participants
@desig9stein @simeonoff