Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): Fix oldSelection when the value is undefined on 14.2.x #12273

Merged

Conversation

katherinedragieva
Copy link
Contributor

@katherinedragieva katherinedragieva commented Nov 7, 2022

Closes #12186

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
coditva Utkarsh Maheshwari
@katherinedragieva katherinedragieva changed the title fix(select): Fix oldSelection when the value is undefined fix(select): Fix oldSelection when the value is undefined on 14.2.x Nov 7, 2022
@hanastasov hanastasov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Nov 8, 2022
@hanastasov hanastasov added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Nov 8, 2022
@ChronosSF ChronosSF merged commit 350f927 into 14.2.x Nov 8, 2022
@ChronosSF ChronosSF deleted the kdragieva/12186-oldSelection-default-value-on-14.2.x branch November 8, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version: 14.2.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type definition - ISelectionEventArgs.oldSelection can be undefined
3 participants