Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(toolbar): to use absolute position so the buttons are always in the view. #12349

Merged
merged 6 commits into from
Dec 8, 2022
Merged

refactor(toolbar): to use absolute position so the buttons are always in the view. #12349

merged 6 commits into from
Dec 8, 2022
+15 −1

Conversation

desig9stein
Copy link
Contributor

@desig9stein desig9stein commented Nov 21, 2022 •
edited
Loading

Closes #12249

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

Sorry, something went wrong.

@desig9stein
refactor(toolbar): to use absolute position so the buttons are allays…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
b148e25 
… in the view.
@desig9stein desig9stein mentioned this pull request Dec 2, 2022
Closed
@simeonoff simeonoff requested review from SisIvanova and removed request for simeonoff December 5, 2022 08:41
@SisIvanova SisIvanova added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Dec 5, 2022
SisIvanova
SisIvanova previously approved these changes Dec 5, 2022
View reviewed changes
@SisIvanova SisIvanova added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Dec 5, 2022
@simeonoff simeonoff changed the base branch from master to 15.0.x December 7, 2022 11:23
@simeonoff simeonoff dismissed SisIvanova’s stale review December 7, 2022 11:23

The base branch was changed.

@simeonoff simeonoff merged commit 99639da into 15.0.x Dec 8, 2022
@simeonoff simeonoff deleted the mpopov/12249 branch December 8, 2022 09:00
@Timmeeeey Timmeeeey mentioned this pull request Jan 12, 2023
Closed
This was referenced Jan 16, 2023
Merged
Merged
@desig9stein desig9stein mentioned this pull request Jan 24, 2023
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SisIvanova SisIvanova

Assignees

@zdrawku zdrawku

@SisIvanova SisIvanova

Labels
grid: toolbar grid version: 15.0.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grid "Pin all" action makes actions area go outside view
4 participants
@desig9stein @SisIvanova @simeonoff @zdrawku